feature: @putout/plugin-promises: apply-to-level-await: useEffect: exclude

Author: coderaiser

packages/plugin-promises/lib/apply-top-level-await/fixture/iife-async-fix.js

@@ -1,11 +1,15 @@
 export default () => {
-    useEffect(async () => {
-        const t = await fs.promises.readFile('hello');
+    useEffect(() => {
+        (async () => {
+            const t = await fs.promises.readFile('hello');
+        })();
     });
 };
 
 export const hello = () => {
-    useEffect(async function() {
-        const t = await fs.promises.readFile('hello');
+    useEffect(function() {
+        (async function() {
+            const t = await fs.promises.readFile('hello');
+        })();
     });
 };

packages/plugin-promises/lib/apply-top-level-await/fixture/iife-async.js

@@ -1,13 +1,13 @@
 export default () => {
-    useEffect(async () => {
+    useEffect(() => {
         (async () => {
             const t = await fs.promises.readFile('hello');
         })();
     });
 };
 
 export const hello = () => {
-    useEffect(async function() {
+    useEffect(function() {
         (async function() {
             const t = await fs.promises.readFile('hello');
         })();

packages/plugin-promises/lib/apply-top-level-await/fixture/use-effect-fix.js

@@ -0,0 +1,8 @@
+import pipe from 'pipe-io';
+
+useEffect(() => {
+    if (a)
+        (async () => {
+            await pipe();
+        })();
+});

packages/plugin-promises/lib/apply-top-level-await/fixture/use-effect.js

@@ -0,0 +1,6 @@
+useEffect(() => {
+    if (a)
+        (async () => {
+            await pipe();
+        })()
+});

packages/plugin-promises/lib/apply-top-level-await/index.js

@@ -1,6 +1,9 @@
 import {operator} from 'putout';
 
-const {replaceWithMultiple} = operator;
+const {
+    replaceWithMultiple,
+    compare,
+} = operator;
 
 const add = ({push, store}) => (path) => {
     const calleePath = path.get('callee');
@@ -54,11 +57,13 @@ export const traverse = ({push, store}) => {
     };
 };
 
+const isInsideUseEffect = (a) => compare(a, 'useEffect(__args)');
+
 function isAsyncParent(path) {
     const {parentPath} = path.parentPath.parentPath;
 
-    if (!parentPath)
-        return true;
+    if (path.find(isInsideUseEffect))
+        return false;
 
-    return !parentPath.isFunction() || parentPath.node.async;
+    return !parentPath;
 }

packages/plugin-promises/lib/apply-top-level-await/index.spec.js

@@ -1,5 +1,7 @@
 import {createTest} from '@putout/test';
+import * as declare from '@putout/plugin-declare';
 import * as applyTopLevelAwait from './index.js';
+import * as addMissingAsync from '../add-missing-async/index.js';
 
 const test = createTest(import.meta.url, {
     plugins: [
@@ -56,3 +58,11 @@ test('plugin-promises: apply-top-level-await: transform: iife-async', (t) => {
     t.transform('iife-async');
     t.end();
 });
+
+test('plugin-add-missing-await: transform: use-effect', (t) => {
+    t.transform('use-effect', {
+        addMissingAsync,
+        declare,
+    });
+    t.end();
+});

packages/plugin-promises/package.json

@@ -31,6 +31,7 @@
     "promises"
   ],
   "devDependencies": {
+    "@putout/plugin-declare": "*",
     "@putout/test": "^14.0.0",
     "c8": "^10.0.0",
     "eslint": "^9.0.0",