feature: @putout/plugin-remove-duplicate-keys: argument name clash support

Author: coderaiser

docs/syntax-errors.md

@@ -329,3 +329,12 @@ function get() {
 ```
 
 </details>
+
+<details><summary>Argument name clash</summary>
+
+```diff
+-const a = ({b, b, ...c}) => {};
++const a = ({b, ...c}) => {};
+```
+
+</details>

packages/plugin-remove-duplicate-keys/README.md

@@ -44,6 +44,17 @@ const a = {
 };
 ```
 
+> SyntaxError: Duplicate parameter name not allowed in this context
+>
+> (c) [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Duplicate_parameter)
+
+Argument name clash:
+
+```diff
+-const a = ({b, b, ...c}) => {};
++const a = ({b, ...c}) => {};
+```
+
 ## License
 
 MIT

packages/plugin-remove-duplicate-keys/lib/remove-duplicate-keys.js

@@ -2,21 +2,21 @@
 
 const {types, operator} = require('putout');
 const fullstore = require('fullstore');
+const {
+    compare,
+    traverseProperties,
+    extract,
+} = operator;
 
 const {
     isSpreadElement,
     isIdentifier,
     isMemberExpression,
     isObjectProperty,
-    isObjectPattern,
     isStringLiteral,
+    isObjectPattern,
 } = types;
 
-const {
-    traverseProperties,
-    extract,
-} = operator;
-
 const isSpreadId = (name) => (a) => isSpreadElement(a) && isIdentifier(a.argument, {
     name,
 });
@@ -54,14 +54,14 @@ module.exports.match = () => ({
         const newProperties = [];
         const {properties} = __object;
 
-        if (isObjectPattern(__object))
-            return false;
-        
         const reversed = properties
             .slice()
             .reverse();
 
         for (const prop of reversed) {
+            if (isObjectPattern(path) && !compare(prop.key, prop.value))
+                continue;
+            
             if (isSpreadElement(prop) && isIdentifier(prop.argument)) {
                 const {name} = prop.argument;
                 const isFirst = checkIfFirst(properties, newProperties, isSpreadId, name);

packages/plugin-remove-duplicate-keys/test/fixture/object-pattern-fix.js

@@ -0,0 +1 @@
+const fix = ({ast, source}) => {};

packages/plugin-remove-duplicate-keys/test/fixture/object-pattern-nested.js

@@ -0,0 +1,8 @@
+const {
+    a: {
+        b,
+    },
+    a: {
+        b: x,
+    },
+} = c;

packages/plugin-remove-duplicate-keys/test/fixture/object-pattern-rename.js

@@ -0,0 +1 @@
+const {b, b: x} = a;

packages/plugin-remove-duplicate-keys/test/fixture/object-pattern.js

@@ -0,0 +1 @@
+const fix = ({ast, source, source}) => {};

packages/plugin-remove-duplicate-keys/test/remove-duplicate-keys.js

@@ -63,3 +63,18 @@ test('remove duplicate-keys: transform: array', (t) => {
     t.transform('array');
     t.end();
 });
+
+test('remove duplicate-keys: transform: object-pattern', (t) => {
+    t.transform('object-pattern');
+    t.end();
+});
+
+test('remove duplicate-keys: no report: object-pattern-rename', (t) => {
+    t.noReport('object-pattern-rename');
+    t.end();
+});
+
+test('remove duplicate-keys: no report: object-pattern-nested', (t) => {
+    t.noReport('object-pattern-nested');
+    t.end();
+});