feature: @putout/eslint: get rid of legacy ESLintRC

Author: coderaiser

packages/eslint/README.md

@@ -50,27 +50,27 @@ Isn't it looks similar to 🐊**Putout** way? It definitely is! But... It has a
 And you can even override any of **ESLint** ⚙️ options with help of `config` property:
 
 ```js
+import {safeAlign} from 'eslint-plugin-putout';
+
 const [source, places] = await eslint({
     name: 'hello.js',
     code: `const t = 'hi'\n`,
     fix: false,
-    config: {
-        extends: ['plugin:putout/recommended'],
-    },
+    config: [safeAlign],
 });
 ```
 
 If you want to apply 🐊**Putout** transformations using [`putout/putout`](https://github.com/coderaiser/putout/tree/master/packages/eslint-plugin-putout#readme) **ESLint** rule, enable 🐊**Putout** with the same called but lowercased flag:
 
 ```js
+import {safeAlign} from 'eslint-plugin-putout';
+
 const [source, places] = await eslint({
     name: 'hello.js',
     code: `const t = 'hi'\n`,
     fix: true,
     putout: true,
-    config: {
-        extends: ['plugin:putout/recommended'],
-    },
+    config: [safeAlign],
 });
 ```
 

packages/eslint/lib/eslint.js

@@ -40,10 +40,6 @@ const noConfigFound = (config, configError) => {
     return !keys(config.rules).length;
 };
 
-const cutNewLine = ({message}) => ({
-    message: message.replace(/\n.*/, ''),
-});
-
 module.exports = async ({name, code, fix, config, putout = false}) => {
     const noChanges = [
         code,
@@ -60,21 +56,13 @@ module.exports = async ({name, code, fix, config, putout = false}) => {
 
     const {getESLint} = ESLint;
 
-    const [eslintError, eslint] = await tryToCatch(getESLint, {
+    const eslint = await getESLint({
         name,
         fix,
         config,
         overrideConfigFile,
     });
 
-    if (eslintError) {
-        const places = [
-            convertToPlace(cutNewLine(eslintError)),
-        ];
-        
-        return [code, places];
-    }
-    
     const [configError, finalConfig] = await tryToCatch(eslint.calculateConfigForFile, name);
 
     if (noConfigFound(finalConfig, configError))

packages/eslint/lib/eslint.spec.js

@@ -419,7 +419,7 @@ test('putout: eslint: get-eslint: config file', async (t) => {
 
     reRequire('./eslint.js');
 
-    t.match(message, /^Cannot read config file/);
+    t.match(message, 'no such file or directory');
     t.end();
 });
 

packages/eslint/lib/get-eslint.mjs

@@ -1,69 +1,14 @@
 import {dirname} from 'node:path';
 import process from 'node:process';
 import {loadESLint} from 'eslint';
-import {findUp} from 'find-up';
 
 const {isArray} = Array;
 const maybeArray = (a) => isArray(a) ? a : [a];
 const CWD = process.cwd();
 
-export const getESLint = async ({name, fix, config, overrideConfigFile, loadESLintOverride, find = findUp, findFlat = find, findRC = find}) => {
+export const getESLint = async ({name, fix, config = [], overrideConfigFile, loadESLintOverride = loadESLint}) => {
     const cwd = dirname(name).replace(/^\./, CWD);
-    const eslint = await chooseESLint({
-        fix,
-        cwd,
-        config,
-        overrideConfigFile,
-        loadESLintOverride,
-        findFlat,
-        findRC,
-    });
-    
-    return {
-        calculateConfigForFile: eslint.calculateConfigForFile.bind(eslint),
-        lintText: eslint.lintText.bind(eslint),
-    };
-};
-
-async function chooseESLint({cwd, config, fix, overrideConfigFile, loadESLintOverride, findFlat, findRC}) {
-    const runESLint = await getESLintRunner({
-        cwd,
-        overrideConfigFile,
-        findFlat,
-        findRC,
-    });
-    
-    return await runESLint({
-        loadESLintOverride,
-        cwd,
-        config,
-        overrideConfigFile,
-        fix,
-    });
-}
-
-async function getOldESLint({cwd, fix, config, overrideConfigFile, loadESLintOverride = loadESLint}) {
-    const ESLint = await loadESLintOverride({
-        useFlatConfig: false,
-    });
-    
-    const eslint = new ESLint({
-        cwd,
-        fix,
-        overrideConfig: {
-            ignorePatterns: ['!.*'],
-            ...config,
-        },
-        ...overrideConfigFile && {
-            overrideConfigFile,
-            useEslintrc: false,
-        },
-    });
 
-    return eslint;
-}
-
-async function getFlatESLint({cwd, fix, config = [], overrideConfigFile, loadESLintOverride = loadESLint}) {
     const FlatESLint = await loadESLintOverride({
         useFlatConfig: true,
     });
@@ -82,29 +27,8 @@ async function getFlatESLint({cwd, fix, config = [], overrideConfigFile, loadESL
         },
     });
 
-    return eslint;
-}
-
-const isFlat = (a) => a?.includes('config');
-
-async function getESLintRunner({cwd, findFlat, findRC, overrideConfigFile}) {
-    if (overrideConfigFile)
-        return isFlat(overrideConfigFile) ? getFlatESLint : getOldESLint;
-    
-    const [rcConfig = '', flatConfig = ''] = await Promise.all([
-        findRC(['.eslintrc.json', '.eslintrc.js'], {
-            cwd,
-        }),
-        findFlat(['eslint.config.js', 'eslint.config.mjs', 'eslint.config.cjs'], {
-            cwd,
-        }),
-    ]);
-    
-    const noConfigFound = !rcConfig && !flatConfig;
-    const foundRConfig = rcConfig.length > flatConfig.length;
-    
-    if (noConfigFound || foundRConfig)
-        return getOldESLint;
-    
-    return getFlatESLint;
-}
+    return {
+        calculateConfigForFile: eslint.calculateConfigForFile.bind(eslint),
+        lintText: eslint.lintText.bind(eslint),
+    };
+};

packages/eslint/lib/get-eslint.spec.mjs

@@ -154,12 +154,10 @@ test('putout: eslint: get-eslint: flat: no overrides', async (t) => {
     });
 
     const loadESLintOverride = stub().resolves(ESLintOverride);
-    const find = stub().returns('/hello/world/eslint.config.js');
 
     await getESLint({
         name: 'index.js',
         loadESLintOverride,
-        find,
         fix: false,
     });
 
@@ -174,104 +172,3 @@ test('putout: eslint: get-eslint: flat: no overrides', async (t) => {
     t.calledWith(ESLintOverride, expected);
     t.end();
 });
-
-test('putout: eslint: get-eslint: flat: no overrides: rc', async (t) => {
-    const lintText = stub();
-    const error = Error('hello');
-    const calculateConfigForFile = stub().rejects(error);
-    
-    const ESLintOverride = stub().returns({
-        calculateConfigForFile,
-        lintText,
-    });
-    
-    const loadESLintOverride = stub().resolves(ESLintOverride);
-    const findRC = stub().returns('/hello/world/.eslintrc.json');
-    const findFlat = stub().returns('/eslint.config.js');
-    
-    await getESLint({
-        name: 'index.js',
-        loadESLintOverride,
-        findRC,
-        findFlat,
-        fix: false,
-    });
-    
-    const expected = [{
-        cwd: CWD,
-        fix: false,
-        overrideConfig: {
-            ignorePatterns: ['!.*'],
-        },
-    }];
-    
-    t.calledWith(ESLintOverride, expected);
-    t.end();
-});
-
-test('putout: eslint: get-eslint: overrideConfigFile: rc', async (t) => {
-    const lintText = stub();
-    const error = Error('hello');
-    const calculateConfigForFile = stub().rejects(error);
-    
-    const ESLintOverride = stub().returns({
-        calculateConfigForFile,
-        lintText,
-    });
-    
-    const loadESLintOverride = stub().resolves(ESLintOverride);
-    const findFlat = stub().returns('/hello/world/eslint.config.js');
-    const findRC = stub().returns('/hello/.eslintrc.json');
-    
-    await getESLint({
-        name: 'index.js',
-        loadESLintOverride,
-        findRC,
-        findFlat,
-        fix: false,
-        overrideConfigFile: '.eslintrc.json',
-    });
-    
-    const expected = [{
-        cwd: CWD,
-        fix: false,
-        overrideConfig: {
-            ignorePatterns: ['!.*'],
-        },
-        overrideConfigFile: '.eslintrc.json',
-        useEslintrc: false,
-    }];
-    
-    t.calledWith(ESLintOverride, expected);
-    t.end();
-});
-
-test('putout: eslint: get-eslint: no RC, no FlatConfig', async (t) => {
-    const lintText = stub();
-    const error = Error('hello');
-    const calculateConfigForFile = stub().rejects(error);
-    
-    const ESLintOverride = stub().returns({
-        calculateConfigForFile,
-        lintText,
-    });
-    
-    const loadESLintOverride = stub().resolves(ESLintOverride);
-    const findFlat = stub().returns('');
-    const findRC = stub().returns('');
-    
-    await getESLint({
-        name: 'index.js',
-        loadESLintOverride,
-        findRC,
-        findFlat,
-        fix: false,
-    });
-    
-    const expected = [{
-        useFlatConfig: false,
-    }];
-    
-    t.calledWith(loadESLintOverride, expected);
-    t.end();
-});

packages/eslint/package.json

@@ -29,7 +29,6 @@
     "report": "madrun report"
   },
   "dependencies": {
-    "find-up": "^7.0.0",
     "once": "^1.4.0",
     "try-to-catch": "^3.0.1"
   },