feature: @putout/plugin-conditions: remove-useless-loop-condition

Author: coderaiser

packages/plugin-conditions/README.md

@@ -26,7 +26,8 @@ npm i @putout/plugin-conditions -D
 - ✅ [remove-boolean](#remove-boolean);
 - ✅ [remove-constant](#remove-constant);
 - ✅ [remove-same-values-condition](hremove-same-values-condition);
-- ✅ [remove-useless-else](#remove-ureless-else);
+- ✅ [remove-useless-else](#remove-useless-else);
+- ✅ [remove-useless-loop-condition](#remove-useless-loop-condition);
 - ✅ [remove-zero](#remove-zero);
 - ✅ [simplify](#simplify);
 - ✅ [wrap-with-block](#wrap-with-block);
@@ -49,6 +50,7 @@ npm i @putout/plugin-conditions -D
         "conditions/remove-constant": "on",
         "conditions/remove-zero": "on",
         "conditions/remove-useless-else": "on",
+        "conditions/remove-useless-loop-condition": "on",
         "conditions/remove-same-values-condition": "on",
         "conditions/merge-if-statements": "on",
         "conditions/simplify": "on",
@@ -406,6 +408,25 @@ Linter | Rule | Fix
 🐊 **Putout** | [`conditions/remove-useless-else`](https://github.com/coderaiser/putout/tree/master/packages/plugin-conditions#remove-useless-else) | ✅
 ⏣ **ESLint** | [`no-else-return`](https://eslint.org/docs/rules/no-else-return) | ✅
 
+## remove-useless-loop-condition
+
+Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/eefe12da089fda5554d394746ee25a6f/7a3c467cb95a5909f6d7f7d8228b5003da674113).
+
+### ❌ Example of incorrect code
+
+```js
+while (currentDirPath = getParentDirectory(currentDirPath)) {
+    if (!currentDirPath)
+        break;
+}
+```
+
+### ✅ Example of correct code
+
+```js
+while (currentDirPath = getParentDirectory(currentDirPath)) {}
+```
+
 ## remove-same-values-condition
 
 Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/e537d4ec636d4a9b849063a8326b70ae/661041b3fbb1e3678bf7f828e4c8bf6ca723f89d).

packages/plugin-conditions/lib/index.js

@@ -16,6 +16,7 @@ const addReturn = require('./add-return');
 const convertArrowToCondition = require('./convert-arrow-to-condition');
 const reverseCondition = require('./reverse-condition');
 const wrapWithBlock = require('./wrap-with-block');
+const removeUselessLoopCondition = require('./remove-useless-loop-condition');
 
 module.exports.rules = {
     'apply-comparison-order': applyComparisonOrder,
@@ -34,4 +35,5 @@ module.exports.rules = {
     'convert-arrow-to-condition': convertArrowToCondition,
     'reverse-condition': reverseCondition,
     'wrap-with-block': wrapWithBlock,
+    'remove-useless-loop-condition': removeUselessLoopCondition,
 };

packages/plugin-conditions/lib/remove-useless-loop-condition/fixture/remove-useless-loop-condition-fix.js

@@ -0,0 +1,3 @@
+while (currentDirPath = getParentDirectory(currentDirPath)) {}
+
+while (currentDirPath = getParentDirectory(currentDirPath)) {}

packages/plugin-conditions/lib/remove-useless-loop-condition/fixture/remove-useless-loop-condition.js

@@ -0,0 +1,9 @@
+while (currentDirPath = getParentDirectory(currentDirPath)) {
+    if (!currentDirPath)
+        break;
+}
+
+while (currentDirPath = getParentDirectory(currentDirPath)) {
+    if (!currentDirPath)
+        continue;
+}

packages/plugin-conditions/lib/remove-useless-loop-condition/index.js

@@ -0,0 +1,28 @@
+'use strict';
+
+const {operator} = require('putout');
+const {
+    getTemplateValues,
+    compare,
+} = operator;
+
+const LOOP = 'while (__c = __d) __body';
+
+module.exports.report = () => `Avoid useless loop condition`;
+
+module.exports.match = () => ({
+    'if (!__a) __b': ({__a}, path) => {
+        const {parentPath} = path.parentPath;
+        
+        if (!compare(parentPath, LOOP))
+            return false;
+        
+        const {__c} = getTemplateValues(parentPath, LOOP);
+        
+        return compare(__a, __c);
+    },
+});
+
+module.exports.replace = () => ({
+    'if (!__a) __b': '',
+});

packages/plugin-conditions/lib/remove-useless-loop-condition/index.spec.js

@@ -0,0 +1,20 @@
+'use strict';
+
+const {createTest} = require('@putout/test');
+const plugin = require('.');
+
+const test = createTest(__dirname, {
+    plugins: [
+        ['remove-useless-loop-condition', plugin],
+    ],
+});
+
+test('conditions: remove-useless-loop-condition: report', (t) => {
+    t.report('remove-useless-loop-condition', `Avoid useless loop condition`);
+    t.end();
+});
+
+test('conditions: remove-useless-loop-condition: transform', (t) => {
+    t.transform('remove-useless-loop-condition');
+    t.end();
+});

packages/plugin-conditions/test/conditions.js

@@ -88,3 +88,8 @@ test('plugin-conditions: transform: wrap-with-block', (t) => {
     t.transform('wrap-with-block');
     t.end();
 });
+
+test('plugin-conditions: transform: remove-useless-loop-condition', (t) => {
+    t.transform('remove-useless-loop-condition');
+    t.end();
+});

packages/plugin-conditions/test/fixture/remove-useless-loop-condition-fix.js

@@ -0,0 +1,3 @@
+while (currentDirPath = getParentDirectory(currentDirPath)) {}
+
+while (currentDirPath = getParentDirectory(currentDirPath)) {}

packages/plugin-conditions/test/fixture/remove-useless-loop-condition.js

@@ -0,0 +1,9 @@
+while (currentDirPath = getParentDirectory(currentDirPath)) {
+    if (!currentDirPath)
+        break;
+}
+
+while (currentDirPath = getParentDirectory(currentDirPath)) {
+    if (!currentDirPath)
+        continue;
+}