feature: @putout/plugin-declare-before-reference: improve uid check

Author: coderaiser

packages/plugin-declare-before-reference/lib/declare-before-reference.js

@@ -16,7 +16,9 @@ const {
 } = types;
 
 const {entries} = Object;
-const isTopScope = (a) => isFunction(a) || isProgram(a) || isBlockStatement(a);
+const isTopScope = (a) => isFunction(a) || isProgram(a);
+const getTopUID = (a) => a.find(isTopScope).scope.uid;
+const getBlockUID = (a) => a.find(isBlockStatement)?.scope.uid;
 
 module.exports.report = ({name}) => {
     return `Declare '${name}' before referencing to avoid 'ReferenceError'`;
@@ -72,9 +74,10 @@ module.exports.traverse = ({push}) => ({
                 break;
 
             for (const referencePath of referencePaths) {
-                const referenceUid = referencePath.find(isTopScope).scope.uid;
+                const referenceUid = getTopUID(referencePath);
+                const blockUid = getBlockUID(referencePath);
 
-                if (uid !== referenceUid && (uid && referencePath.find(isFunction)))
+                if (uid !== referenceUid && uid !== blockUid)
                     continue;
 
                 if (referencePath.parentPath.isExportDefaultDeclaration())

packages/plugin-declare-before-reference/test/declare-before-reference.js

@@ -102,6 +102,11 @@ test('plugin-declare-before-reference: transform: destructuring', (t) => {
     t.end();
 });
 
+test('plugin-declare-before-reference: no report: different-scopes', (t) => {
+    t.noReport('different-scopes');
+    t.end();
+});
+
 test('plugin-declare-before-reference: no report: apply-types', (t) => {
     t.noReportAfterTransform('apply-types', {
         'apply-types': printer.rules['apply-types'],

packages/plugin-declare-before-reference/test/fixture/different-scopes.js

@@ -0,0 +1,5 @@
+export const x = () => {
+    run();
+};
+
+const run = () => {};