feature: @putout/plugin-apply-shorthand-properties: computed

Author: coderaiser

packages/plugin-apply-shorthand-properties/lib/apply-shorthand-properties.js

@@ -1,7 +1,15 @@
 import {types, operator} from 'putout';
 
-const {findBinding, rename} = operator;
-const {isImportSpecifier} = types;
+const {
+    findBinding,
+    rename,
+    replaceWith,
+} = operator;
+
+const {
+    isImportSpecifier,
+    identifier,
+} = types;
 
 export const report = () => `Use shorthand properties`;
 
@@ -15,6 +23,13 @@ export const fix = ({path, from, to, toRename}) => {
         rename(path, from, to);
 
     path.node.shorthand = true;
+    
+    const keyPath = path.get('key');
+    
+    if (keyPath.isStringLiteral()) {
+        replaceWith(keyPath, identifier(keyPath.node.value));
+        path.node.computed = false;
+    }
 };
 
 export const traverse = ({push, options}) => ({
@@ -31,20 +46,20 @@ export const traverse = ({push, options}) => ({
             if (shorthand)
                 continue;
 
-            if (computed)
-                continue;
-            
             const valuePath = propPath.get('value');
             const keyPath = propPath.get('key');
 
+            if (computed && !keyPath.isStringLiteral())
+                continue;
+            
+            if (!computed && keyPath.isStringLiteral())
+                continue;
+            
             const {rename, ignore = []} = options;
 
             const from = getName(valuePath);
             const to = getName(keyPath);
 
-            if (!to)
-                continue;
-            
             if (ignore.includes(from))
                 continue;
 
@@ -92,5 +107,8 @@ function getName(path) {
     if (path.isIdentifier())
         return node.name;
 
+    if (path.isStringLiteral())
+        return node.value;
+    
     return '';
 }

packages/plugin-apply-shorthand-properties/test/apply-shorthand-properties.js

@@ -104,8 +104,8 @@ test('plugin-apply-shorthand-properties: no transform: import-declaration', (t)
     t.end();
 });
 
-test('plugin-apply-shorthand-properties: no report: computed', (t) => {
-    t.noReport('computed');
+test('plugin-apply-shorthand-properties: transform: computed', (t) => {
+    t.transform('computed');
     t.end();
 });
 

packages/plugin-apply-shorthand-properties/test/fixture/computed-fix.js

@@ -0,0 +1,8 @@
+fn({
+    x,
+    'y': y,
+});
+
+const a = {
+    [hello]: hello,
+};

packages/plugin-apply-shorthand-properties/test/fixture/computed.js

@@ -1,3 +1,8 @@
+fn({
+    ['x']: x,
+    'y': y,
+});
+
 const a = {
     [hello]: hello,
-}
+};