feature: @putout/plugin-nodejs: apply-global-this: add

coderaiser · coderaiser · commit 710c5f16d33e · 2025-12-25T19:18:26.000+02:00
diff --git a/packages/compare/lib/debug.js b/packages/compare/lib/debug.js
@@ -7,11 +7,11 @@ module.exports.createDebug = (namespace) => {
     
     return new Proxy(log, {
         apply(target, thisArg, args) {
-            global.__putout_debug?.(namespace, ...args);
+            globalThis.__putout_debug?.(namespace, ...args);
             return target(...args);
         },
         get(target, prop) {
-            if (global.__putout_debug?.[prop])
+            if (globalThis.__putout_debug?.[prop])
                 return true;
             
             return target[prop];
diff --git a/packages/compare/lib/log.spec.js b/packages/compare/lib/log.spec.js
@@ -12,9 +12,9 @@ test('putout: compare: log', (t) => {
     const debug = stub();
     
     debug.enabled = true;
-    global.__putout_debug = debug;
+    globalThis.__putout_debug = debug;
     log('hello', 'world');
-    delete global.__putout_debug;
+    delete globalThis.__putout_debug;
     
     const expected = [
         'putout:compare',
@@ -29,10 +29,10 @@ test('putout: compare: run-plugins: template: log: array', (t) => {
     const debug = stub();
     
     debug.enabled = true;
-    global.__putout_debug = debug;
+    globalThis.__putout_debug = debug;
     
     log([identifier('hello')], [identifier('world')]);
-    delete global.__putout_debug;
+    delete globalThis.__putout_debug;
     
     const expected = [
         'putout:compare',
@@ -47,10 +47,10 @@ test('putout: compare: log: object', (t) => {
     const debug = stub();
     
     debug.enabled = true;
-    global.__putout_debug = debug;
+    globalThis.__putout_debug = debug;
     
     log(identifier('hello'), identifier('world'));
-    delete global.__putout_debug;
+    delete globalThis.__putout_debug;
     
     const expected = [
         'putout:compare',
diff --git a/packages/engine-runner/lib/debug.js b/packages/engine-runner/lib/debug.js
@@ -7,11 +7,11 @@ module.exports.createDebug = (namespace) => {
     
     return new Proxy(log, {
         apply(target, thisArg, args) {
-            global.__putout_debug?.(namespace, ...args);
+            globalThis.__putout_debug?.(namespace, ...args);
             return target(...args);
         },
         get(target, prop) {
-            if (global.__putout_debug?.[prop])
+            if (globalThis.__putout_debug?.[prop])
                 return true;
             
             return target[prop];
diff --git a/packages/engine-runner/lib/run-fix.spec.js b/packages/engine-runner/lib/run-fix.spec.js
@@ -36,7 +36,7 @@ test('fix: error: nested path: debug', (t) => {
     
     debugFn.enabled = true;
     
-    global.__putout_debug = stub().returns(debugFn);
+    globalThis.__putout_debug = stub().returns(debugFn);
     
     const remove = () => {
         throw Error('hello');
@@ -60,19 +60,19 @@ test('fix: error: nested path: debug', (t) => {
         position,
     });
     
-    delete global.__putout_debug;
+    delete globalThis.__putout_debug;
     
     t.equal(e.loc, position);
     t.end();
 });
 
 test('fix: error: nested path: debug: nested path', (t) => {
-    const {__putout_debug} = global;
+    const {__putout_debug} = globalThis;
     const debugFn = stub();
     
     debugFn.enabled = true;
     
-    global.__putout_debug = stub().returns(debugFn);
+    globalThis.__putout_debug = stub().returns(debugFn);
     
     const remove = () => {
         throw Error('hello');
@@ -98,7 +98,7 @@ test('fix: error: nested path: debug: nested path', (t) => {
         position,
     });
     
-    global.__putout_debug = __putout_debug;
+    globalThis.__putout_debug = __putout_debug;
     
     t.equal(e.loc, position);
     t.end();
diff --git a/packages/engine-runner/lib/template/index.spec.js b/packages/engine-runner/lib/template/index.spec.js
@@ -437,26 +437,26 @@ test('putout: plugin: traverse: template: log', (t) => {
 
 test('putout: engine: runner: template: log', (t) => {
     const debug = stub();
-    const {__putout_debug} = global;
+    const {__putout_debug} = globalThis;
     
-    global.__putout_debug = stub().returns(debug);
+    globalThis.__putout_debug = stub().returns(debug);
     
     _log();
-    global.__putout_debug = __putout_debug;
+    globalThis.__putout_debug = __putout_debug;
     
     t.notCalled(debug, 'should call debug');
     t.end();
 });
 
 test('putout: engine: runner: template: log: enabled', (t) => {
-    const {__putout_debug} = global;
+    const {__putout_debug} = globalThis;
     const debug = stub();
     
     debug.enabled = true;
-    global.__putout_debug = debug;
+    globalThis.__putout_debug = debug;
     
     _log('rule', 'path');
-    global.__putout_debug = __putout_debug;
+    globalThis.__putout_debug = __putout_debug;
     
     t.calledWith(debug, ['putout:runner:template', 'rule', 'path'], 'should call debug');
     t.end();
diff --git a/packages/engine-runner/test/runner.js b/packages/engine-runner/test/runner.js
@@ -732,7 +732,7 @@ test('putout: runner: debug', (t) => {
     
     debugFn.enabled = true;
     
-    global.__putout_debug = stub().returns(debugFn);
+    globalThis.__putout_debug = stub().returns(debugFn);
     
     const {code} = putout(fixture.debug, {
         fix: true,
@@ -755,7 +755,7 @@ test('putout: runner: debug: replace', (t) => {
     const debugFn = stub();
     
     debugFn.enabled = true;
-    global.__putout_debug = debugFn;
+    globalThis.__putout_debug = debugFn;
     
     process.env.DEBUG = 'putout:runner:fix';
     
@@ -770,7 +770,7 @@ test('putout: runner: debug: replace', (t) => {
     ];
     
     process.env.DEBUG = DEBUG;
-    delete global.__putout_debug;
+    delete globalThis.__putout_debug;
     
     t.calledWith(debugFn, expected);
     t.end();
diff --git a/packages/plugin-nodejs/README.md b/packages/plugin-nodejs/README.md
@@ -19,6 +19,7 @@ npm i putout @putout/plugin-nodejs -D
 
 - ✅ [add-node-prefix](#add-node-prefix);
 - ✅ [add-missing-strict-mode](#add-missing-strict-mode);
+- ✅ [apply-global-this](#apply-global-this);
 - ✅ [convert-buffer-to-buffer-alloc](#convert-buffer-to-buffer-alloc);
 - ✅ [convert-commonjs-to-esm](#convert-commonjs-to-esm);
 - ✅ [convert-dirname-to-url](#convert-dirname-to-url);
@@ -45,13 +46,15 @@ npm i putout @putout/plugin-nodejs -D
 ```json
 {
     "rules": {
+        "nodejs/add-missing-strict-mode": "on",
+        "nodejs/add-node-prefix": "on",
+        "nodejs/apply-global-this": "off",
         "nodejs/convert-commonjs-to-esm": "off",
         "nodejs/convert-esm-to-commonjs": "off",
         "nodejs/cjs-file": "off",
         "nodejs/mjs-file": "off",
         "nodejs/rename-file-cjs-to-js": "off",
         "nodejs/rename-file-mjs-to-js": "off",
-        "nodejs/add-node-prefix": "on",
         "nodejs/convert-buffer-to-buffer-alloc": "on",
         "nodejs/convert-fs-promises": "on",
         "nodejs/convert-promisify-to-fs-promises": "on",
@@ -63,7 +66,6 @@ npm i putout @putout/plugin-nodejs -D
         "nodejs/declare-after-require": "on",
         "nodejs/group-require-by-id": "on",
         "nodejs/remove-process-exit": "on",
-        "nodejs/add-missing-strict-mode": "on",
         "nodejs/remove-useless-strict-mode": "on",
         "nodejs/remove-illegal-strict-mode": "on",
         "nodejs/remove-useless-promisify": "on"
@@ -101,9 +103,36 @@ await import('node:path');
 
 Linter | Rule | Fix
 --------|-------|------------|
-🐊 **Putout** | [`apply-node-prefix`](https://github.com/coderaiser/putout/tree/master/packages/plugin-nodejs/apply-node-prefix#readme) | ✅
+🐊 **Putout** | [`add-node-prefix`](https://github.com/coderaiser/putout/tree/master/packages/plugin-nodejs/add-node-prefix#readme) | ✅
 ⏣ **ESLint** | [`prefer-node-protocol`](https://github.com/eslint-community/eslint-plugin-n/blob/master/docs/rules/prefer-node-protocol.md#readme)  | ✅
 
+## apply-global-this
+
+> Legacy. Use `globalThis` instead.
+>
+> (c) [nodejs.org](https://nodejs.org/api/globals.html#global)
+
+Check out in 🐊[Putout Editor](https://putout.cloudcmd.io/#/gist/c72c8e1b1d0c2b45fd0d15d837dcae52/c7f33d77d19efe962339debbcf20f68bf2159aee).
+
+### ❌ Example of incorrect code
+
+```js
+global.__putout_debug = debugFn;
+```
+
+### ✅ Example of correct code
+
+```js
+globalThis.__putout_debug = debugFn;
+```
+
+### Comparison
+
+Linter | Rule | Fix
+-------|------|------------|
+🐊 **Putout** | [`apply-global-this`](https://github.com/coderaiser/putout/tree/master/packages/plugin-nodejs/apply-node-prefix#readme) | ✅
+⏣ **ESLint**  | [`no-node-globals`](https://docs.deno.com/lint/rules/no-node-globals/)  | ❌
+
 ## convert-buffer-to-buffer-alloc
 
 > The `Buffer()` function and `new Buffer()` constructor are **deprecated** due to API usability issues that can lead to accidental security issues.
diff --git a/packages/plugin-nodejs/lib/apply-global-this/fixture/apply-global-this-fix.js b/packages/plugin-nodejs/lib/apply-global-this/fixture/apply-global-this-fix.js
@@ -0,0 +1,4 @@
+globalThis.__putout_debug = debugFn;
+delete globalThis.__putout_debug;
+const {__putout_debug} = globalThis;
+const fn = globalThis.unlinkSync || unlinkSync;
diff --git a/packages/plugin-nodejs/lib/apply-global-this/fixture/apply-global-this.js b/packages/plugin-nodejs/lib/apply-global-this/fixture/apply-global-this.js
@@ -0,0 +1,4 @@
+global.__putout_debug = debugFn;
+delete global.__putout_debug;
+const {__putout_debug} = global;
+const fn = global.unlinkSync || unlinkSync;
diff --git a/packages/plugin-nodejs/lib/apply-global-this/index.js b/packages/plugin-nodejs/lib/apply-global-this/index.js
@@ -0,0 +1,6 @@
+export const report = () => `Use 'globalThis' instead of 'global'`;
+
+export const replace = () => ({
+    'global.__a': 'globalThis.__a',
+    'const __a = global': 'const __a = globalThis',
+});
diff --git a/packages/plugin-nodejs/lib/apply-global-this/index.spec.js b/packages/plugin-nodejs/lib/apply-global-this/index.spec.js
@@ -0,0 +1,18 @@
+import {createTest} from '@putout/test';
+import * as plugin from './index.js';
+
+const test = createTest(import.meta.url, {
+    plugins: [
+        ['nodejs/apply-global-this', plugin],
+    ],
+});
+
+test('putout: nodejs: apply-global-this: report', (t) => {
+    t.report('apply-global-this', `Use 'globalThis' instead of 'global'`);
+    t.end();
+});
+
+test('putout: nodejs: apply-global-this: transform', (t) => {
+    t.transform('apply-global-this');
+    t.end();
+});
diff --git a/packages/plugin-nodejs/lib/index.js b/packages/plugin-nodejs/lib/index.js
@@ -1,3 +1,4 @@
+import * as applyGlobalThis from './apply-global-this/index.js';
 import * as convertBufferToBufferAlloc from './convert-buffer-to-buffer-alloc/index.js';
 import * as convertFsPromises from './convert-fs-promises/index.js';
 import * as convertPromisifyToFsPromises from './convert-promisify-to-fs-promises/index.js';
@@ -50,4 +51,5 @@ export const rules = {
     'remove-illegal-strict-mode': strictMode.rules['remove-illegal'],
     'remove-useless-promisify': removeUselessPromisify,
     'group-require-by-id': groupRequireById,
+    'apply-global-this': applyGlobalThis,
 };
diff --git a/packages/plugin-nodejs/test/fixture/apply-global-this-fix.js b/packages/plugin-nodejs/test/fixture/apply-global-this-fix.js
@@ -0,0 +1,6 @@
+import {unlinkSync} from 'node:fs';
+
+globalThis.__putout_debug = debugFn;
+delete globalThis.__putout_debug;
+const {__putout_debug} = globalThis;
+const fn = globalThis.unlinkSync || unlinkSync;
diff --git a/packages/plugin-nodejs/test/fixture/apply-global-this.js b/packages/plugin-nodejs/test/fixture/apply-global-this.js
@@ -0,0 +1,4 @@
+global.__putout_debug = debugFn;
+delete global.__putout_debug;
+const {__putout_debug} = global;
+const fn = global.unlinkSync || unlinkSync;
diff --git a/packages/plugin-nodejs/test/nodejs.js b/packages/plugin-nodejs/test/nodejs.js
@@ -111,3 +111,8 @@ test('plugin-nodejs: transform: group-require-by-id', (t) => {
     t.transform('group-require-by-id');
     t.end();
 });
+
+test('plugin-nodejs: transform: apply-global-this', (t) => {
+    t.transform('apply-global-this');
+    t.end();
+});
diff --git a/packages/test/lib/eslint/eslint.mjs b/packages/test/lib/eslint/eslint.mjs
@@ -22,7 +22,7 @@ const {isArray} = Array;
 const isUpdate = () => process.env.UPDATE === '1';
 
 const update = (name, data) => {
-    const fn = global.writeFileSync || writeFileSync;
+    const fn = globalThis.writeFileSync || writeFileSync;
     fn(name, data);
 };
 
@@ -31,7 +31,7 @@ const remove = (name) => {
     const base = basename(name, ext);
     const fixtureName = name.replace(base, `${base}-fix`);
     
-    const fn = global.unlinkSync || unlinkSync;
+    const fn = globalThis.unlinkSync || unlinkSync;
     
     tryCatch(fn, String(fixtureName));
 };
diff --git a/packages/test/lib/eslint/eslint.spec.mjs b/packages/test/lib/eslint/eslint.spec.mjs
@@ -36,12 +36,12 @@ test('test: eslint: process: UPDATE: stub', async ({process, calledWith}) => {
     update(1);
     const writeFileSync = stub();
     
-    global.writeFileSync = writeFileSync;
+    globalThis.writeFileSync = writeFileSync;
     
     await process('process');
     
     update();
-    delete global.writeFileSync;
+    delete globalThis.writeFileSync;
     
     const name = join(__dirname, 'fixture', 'process-fix.js');
     const data = 'const a = 5;\n\n';
@@ -50,16 +50,16 @@ test('test: eslint: process: UPDATE: stub', async ({process, calledWith}) => {
 }, NOT_CHECK_ASSERTIONS_COUNT);
 
 test('test: eslint: noProcess: UPDATE', async ({noProcess, calledWith}) => {
-    const {unlinkSync} = global;
+    const {unlinkSync} = globalThis;
     const unlinkStub = stub();
     
-    global.unlinkSync = unlinkStub();
+    globalThis.unlinkSync = unlinkStub();
     
     update(1);
     await noProcess('no-process');
     update();
     
-    global.unlinkSync = unlinkSync;
+    globalThis.unlinkSync = unlinkSync;
     
     calledWith(unlinkStub, []);
 }, NOT_CHECK_ASSERTIONS_COUNT);
@@ -68,12 +68,12 @@ test('test: eslint: noProcess: UPDATE: stub', async ({noProcess, calledWith}) =>
     update(1);
     const unlinkSync = stub();
     
-    global.unlinkSync = unlinkSync;
+    globalThis.unlinkSync = unlinkSync;
     
     await noProcess('no-process');
     
     update();
-    delete global.unlinkSync;
+    delete globalThis.unlinkSync;
     
     const name = join(__dirname, 'fixture', 'no-process-fix.js');
     
diff --git a/packages/test/lib/fixture.js b/packages/test/lib/fixture.js
diff --git a/packages/test/lib/processor/index.js b/packages/test/lib/processor/index.js
diff --git a/packages/test/lib/processor/index.spec.js b/packages/test/lib/processor/index.spec.js
diff --git a/packages/test/lib/processor/index.spec.mjs b/packages/test/lib/processor/index.spec.mjs
diff --git a/packages/test/lib/test.js b/packages/test/lib/test.js
diff --git a/packages/test/test/extension.js b/packages/test/test/extension.js
diff --git a/packages/test/test/format.mjs b/packages/test/test/format.mjs
diff --git a/packages/test/test/transform.js b/packages/test/test/transform.js
