feature: @putout/plugin-for-of: remove-useless-variables: check for VariableDeclarator before getting init

Author: coderaiser

packages/plugin-for-of/lib/remove-useless-variables/fixture/no-declaration-fix.js

@@ -0,0 +1 @@
+for (const file of list) {}

packages/plugin-for-of/lib/remove-useless-variables/fixture/no-declaration.js

@@ -1,3 +1,6 @@
-for (a of b) {
-    const {b, c, x} = a;
+console.log(filename);
+const result = {};
+
+for (const file of list) {
+    console.log(file);
 }

packages/plugin-for-of/lib/remove-useless-variables/index.js

@@ -36,11 +36,7 @@ module.exports.traverse = ({push, options}) => ({
         const [referencePath] = referencePaths;
         const {parentPath} = referencePath;
 
-        const isSameName = parentPath.get('init').isIdentifier({
-            name,
-        });
-        
-        if (!isSameName)
+        if (!parentPath.isVariableDeclarator())
             return;
 
         const idPath = parentPath.get('id');

packages/plugin-for-of/lib/remove-useless-variables/index.spec.js

@@ -1,8 +1,12 @@
 'use strict';
 
 const {createTest} = require('@putout/test');
-const plugin = require('.');
+
+const removeUnusedVariables = require('@putout/plugin-remove-unused-variables');
+const removeConsole = require('@putout/plugin-remove-console');
+
 const removeUselessArrayFrom = require('../remove-useless-array-from');
+const plugin = require('.');
 
 const test = createTest(__dirname, {
     plugins: [
@@ -55,6 +59,14 @@ test('putout: plugin-for-of: remove-useless-variables no transform: nested', (t)
     t.end();
 });
 
+test('putout: plugin-for-of: remove-useless-variables no report: no-declaration', (t) => {
+    t.transform('no-declaration', {
+        'remove-console': removeConsole,
+        'remove-unused-variables': removeUnusedVariables,
+    });
+    t.end();
+});
+
 test('putout: plugin-for-of: remove-useless-variables transform with: array-from', (t) => {
     t.transform('array-from', {
         'remove-useless-array-from': removeUselessArrayFrom,

packages/plugin-for-of/package.json

@@ -35,6 +35,7 @@
     "@putout/eslint-flat": "^2.0.0",
     "@putout/plugin-conditions": "*",
     "@putout/plugin-convert-const-to-let": "*",
+    "@putout/plugin-remove-console": "*",
     "@putout/plugin-remove-empty": "*",
     "@putout/plugin-remove-nested-blocks": "*",
     "@putout/plugin-remove-unreferenced-variables": "*",