feature: @putout/plugin-types: convert-typeof-to-is-type: declared

Author: coderaiser

packages/plugin-types/lib/convert-typeof-to-is-type/fixture/declare-before-reference-fix.js

@@ -0,0 +1,11 @@
+const {isArray} = Array;
+
+export const c = () => {
+    const b = isArray(a) ? [] : {};
+    const m = x[i];
+    const value = object[key];
+    
+    if (isArray(object)) {}
+    
+    const isObject = isObject(value);
+};

packages/plugin-types/lib/convert-typeof-to-is-type/fixture/declare-before-reference.js

@@ -0,0 +1,11 @@
+const {isArray} = Array;
+
+export const c = () => {
+    const b = isArray(a) ? [] : {};
+    const m = x[i];
+    const value = object[key];
+    
+    if (isArray(object)) {}
+    
+    const isObject = value instanceof Object;
+};

packages/plugin-types/lib/convert-typeof-to-is-type/index.js

@@ -1,6 +1,10 @@
 import {operator} from 'putout';
 
-const {compare, getBindingPath} = operator;
+const {
+    compare,
+    getBindingPath,
+    extract,
+} = operator;
 
 const NAMES = {
     function: 'isFn',
@@ -10,6 +14,7 @@ const NAMES = {
     undefined: 'isUndefined',
     symbol: 'isSymbol',
     bigint: 'isBigInt',
+    Object: 'isObject',
 };
 
 const EQUAL = 'typeof __a === "__b"';
@@ -53,10 +58,11 @@ export const report = () => `Use function to check type instead of 'typeof' or '
 export const match = () => ({
     [EQUAL]: check,
     [NOT_EQUAL]: check,
-    [EQUAL_INSTANCE_OF]: check,
+    
     [NOT_EQUAL_INSTANCE_OF]: check,
     [EQUAL_UNDEFINED]: check,
     [NOT_EQUAL_UNDEFINED]: check,
+    [EQUAL_INSTANCE_OF]: check,
 });
 
 export const replace = () => ({
@@ -88,7 +94,7 @@ function check({__a, __b}, path) {
     if (path.parentPath.isFunction())
         return false;
 
-    if (__b && isBind(path, __b.value))
+    if (__b && isBind(path, extract(__b)))
         return false;
 
     return getBindingPath(path, __a);
@@ -103,7 +109,13 @@ function isBind(path, name) {
         return false;
 
     if (bindingPath.isVariableDeclarator()) {
-        const {body} = bindingPath.node.init;
+        const initPath = bindingPath.get('init');
+        
+        if (!initPath.isFunction())
+            return true;
+        
+        const {body} = initPath.node;
+        
         return !compare(body, fnBody);
     }
 

packages/plugin-types/lib/convert-typeof-to-is-type/index.spec.js

@@ -1,4 +1,5 @@
 import {createTest} from '@putout/test';
+import * as declareBeforeReference from '@putout/plugin-declare-before-reference';
 import * as convertTypeofToIsType from './index.js';
 
 const test = createTest(import.meta.url, {
@@ -81,3 +82,10 @@ test('plugin-convert-typeof-to-is-type: no transform: not-declared', (t) => {
     t.noTransform('not-declared');
     t.end();
 });
+
+test('plugin-convert-typeof-to-is-type: no report: declare-before-reference', (t) => {
+    t.noReport('declare-before-reference', [
+        ['declare-before-reference', declareBeforeReference],
+    ]);
+    t.end();
+});

packages/plugin-types/package.json

@@ -32,6 +32,7 @@
   ],
   "devDependencies": {
     "@putout/eslint-flat": "^3.0.0",
+    "@putout/plugin-declare-before-reference": "*",
     "@putout/plugin-putout": "*",
     "@putout/test": "^14.0.0",
     "c8": "^10.0.0",