feature: @putout/plugin-destructuring: apply-declarations-order: add

Author: coderaiser

packages/plugin-destructuring/README.md

@@ -17,8 +17,9 @@ npm i @putout/plugin-destructuring
 
 ## Rules
 
-- ✅ [apply-object](#apply-object);
 - ✅ [apply-array](#apply-array);
+- ✅ [apply-object](#apply-object);
+- ✅ [apply-declarations-order](#apply-declarations-order);
 - ✅ [convert-object-to-array](#convert-object-to-array);
 - ✅ [extract-properties](#extract-properties);
 - ✅ [remove-useless-object](#remove-useless-object);
@@ -33,8 +34,9 @@ npm i @putout/plugin-destructuring
 ```json
 {
     "rules": {
-        "destructuring/apply-object": "on",
         "destructuring/apply-array": "on",
+        "destructuring/apply-object": "on",
+        "destructuring/apply-declarations-order": "on",
         "destructuring/convert-object-to-array": "on",
         "destructuring/extract-properties": "on",
         "destructuring/remove-useless-object": "on",
@@ -79,6 +81,24 @@ const {name} = user;
 ({hello} = world);
 ```
 
+## apply-declarations-order
+
+Helps to [extract-properties](#extract-properties'). Checkout in 🐊[**Putout Editor**](https://putout.vercel.app/#/gist/b70ff926b36e1e97ec7129aa0e0458a7/ece0a706de2fd24a66b4671284f7f75017f3c268).
+
+### ❌ Example of incorrect code
+
+```js
+const {env} = require('node:process');
+const process = require('node:process');
+```
+
+### ✅ Example of correct code
+
+```js
+const process = require('node:process');
+const {env} = process;
+```
+
 ## remove-useless-object
 
 Check out in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/c9ed04b421d75ae39e58038fa6e14630/4c097e3173990ec7e5ebabbe2cedf8e952092ebf).

packages/plugin-destructuring/lib/apply-declarations-order/fixture/apply-declarations-order-fix.js

@@ -0,0 +1,2 @@
+const process = require('node:process');
+const {env} = require('node:process');

packages/plugin-destructuring/lib/apply-declarations-order/fixture/apply-declarations-order.js

@@ -0,0 +1,2 @@
+const {env} = require('node:process');
+const process = require('node:process');

packages/plugin-destructuring/lib/apply-declarations-order/index.js

@@ -0,0 +1,40 @@
+import {types, operator} from 'putout';
+
+const {
+    insertAfter,
+    remove,
+    compare,
+    getTemplateValues,
+} = operator;
+
+const {
+    isVariableDeclaration,
+    isIdentifier,
+} = types;
+
+export const report = () => `Apply declarations order`;
+
+export const fix = ({path, current}) => {
+    const {node} = current;
+    remove(current);
+    insertAfter(path, node);
+};
+
+export const traverse = ({push}) => ({
+    'const __a = __b': (path) => {
+        const {__a, __b} = getTemplateValues(path, 'const __a = __b');
+        
+        if (!isIdentifier(__a))
+            return;
+        
+        const prev = path.getAllPrevSiblings();
+        
+        for (const current of prev.filter(isVariableDeclaration)) {
+            if (compare(__b, current.node.declarations[0].init))
+                push({
+                    current,
+                    path,
+                });
+        }
+    },
+});

packages/plugin-destructuring/lib/apply-declarations-order/index.spec.js

@@ -0,0 +1,18 @@
+import {createTest} from '@putout/test';
+import * as plugin from './index.js';
+
+const test = createTest(import.meta.url, {
+    plugins: [
+        ['apply-declarations-order', plugin],
+    ],
+});
+
+test('destructuring: apply-declarations-order: report', (t) => {
+    t.report('apply-declarations-order', `Apply declarations order`);
+    t.end();
+});
+
+test('destructuring: apply-declarations-order: transform', (t) => {
+    t.transform('apply-declarations-order');
+    t.end();
+});

packages/plugin-destructuring/lib/index.js

@@ -1,3 +1,4 @@
+import * as applyDeclarationsOrder from './apply-declarations-order/index.js';
 import * as applyObject from './apply-object/index.js';
 import * as applyArray from './apply-array/index.js';
 import * as extractPropertiesEqualDeep from './extract-properties-equal-deep/index.js';
@@ -11,8 +12,9 @@ import * as splitCall from './split-call/index.js';
 import * as mergeProperties from './merge-properties/index.js';
 
 export const rules = {
-    'apply-object': applyObject,
     'apply-array': applyArray,
+    'apply-object': applyObject,
+    'apply-declarations-order': applyDeclarationsOrder,
     'convert-object-to-array': convertObjectToArray,
     'extract-properties-equal-deep': extractPropertiesEqualDeep,
     'extract-properties-not-equal-deep': extractPropertiesNotEqualDeep,

packages/plugin-destructuring/package.json

@@ -23,7 +23,9 @@
     "coverage": "madrun coverage",
     "report": "madrun report"
   },
-  "dependencies": {},
+  "dependencies": {
+    "redput": "^3.6.0"
+  },
   "keywords": [
     "putout",
     "putout-plugin",

packages/plugin-destructuring/test/destructuring.js

@@ -91,3 +91,8 @@ test('plugin-destructuring: transform: extract-properties-not-equal-deep', (t) =
     t.transform('extract-properties-not-equal-deep');
     t.end();
 });
+
+test('plugin-destructuring: transform: apply-declarations-order', (t) => {
+    t.transform('apply-declarations-order');
+    t.end();
+});

packages/plugin-destructuring/test/fixture/apply-declarations-order-fix.js

@@ -0,0 +1,2 @@
+const process = require('node:process');
+const {env} = require('node:process');

packages/plugin-destructuring/test/fixture/apply-declarations-order.js

@@ -0,0 +1,2 @@
+const {env} = require('node:process');
+const process = require('node:process');