feature: @putout/plugin-declare-before-reference: remove-useless-arguments

Author: coderaiser

packages/plugin-declare-before-reference/lib/declare-before-reference.js

@@ -145,8 +145,11 @@ function getName(path) {
     } while (path = path.get('object'));
 }
 
-function getKeys(path) {
-    const {id} = path.node;
+function getKeys({node}) {
+    if (!node)
+        return [];
+    
+    const {id} = node;
 
     if (!id)
         return [];

packages/plugin-declare-before-reference/package.json

@@ -38,6 +38,8 @@
     "@putout/plugin-promises": "*",
     "@putout/plugin-putout": "*",
     "@putout/plugin-remove-nested-blocks": "*",
+    "@putout/plugin-remove-useless-arguments": "*",
+    "@putout/plugin-remove-useless-variables": "*",
     "@putout/plugin-reuse-duplicate-init": "*",
     "@putout/plugin-tape": "*",
     "@putout/plugin-try-catch": "*",

packages/plugin-declare-before-reference/test/declare-before-reference.js

@@ -7,6 +7,8 @@ import * as removeNestedBlocks from '@putout/plugin-remove-nested-blocks';
 import * as nodejs from '@putout/plugin-nodejs';
 import * as reuseDuplicateInit from '@putout/plugin-reuse-duplicate-init';
 import * as tape from '@putout/plugin-tape';
+import * as removeUselessVariables from '@putout/plugin-remove-useless-variables';
+import * as removeUselessArguments from '@putout/plugin-remove-useless-arguments';
 import * as declare from '../lib/declare-before-reference.js';
 
 const addTEnd = tape.rules['add-t-end'];
@@ -143,3 +145,11 @@ test('plugin-declare-before-reference: no report: cross-reference', (t) => {
     t.noReport('cross-reference');
     t.end();
 });
+
+test('plugin-declare-before-reference: transform: remove-useless-variables', (t) => {
+    t.transform('remove-useless-variables', {
+        'remove': removeUselessVariables.rules.remove,
+        'remove-useless-arguments': removeUselessArguments,
+    });
+    t.end();
+});

packages/plugin-declare-before-reference/test/fixture/cross-reference-fix.js

@@ -0,0 +1,7 @@
+const log = () => {};
+
+const x = {
+    #default_stateChangeHandler(state, oldState) {
+        log();
+    },
+};

packages/plugin-declare-before-reference/test/fixture/remove-useless-variables-fix.js

@@ -0,0 +1,8 @@
+const noop = () => {};
+const log = noop;
+
+const x = {
+    #default_stateChangeHandler(state, oldState) {
+        log(`state change: ${oldState} -> ${state}`);
+    }
+};