feature: @putout/plugin-putout: add-traverse-args: options

Author: coderaiser

packages/plugin-putout/lib/add-traverse-args/fixture/options-declared-upper.js

@@ -0,0 +1,10 @@
+const options = {
+    blacklist,
+};
+
+module.exports.traverse = ({push}) => ({
+    RegExpLiteral(path) {
+        const {pattern, flags} = path.node;
+        const [error, result] = tryCatch(optimize, RegExp(pattern, flags), whitelist, options);
+    }
+});

packages/plugin-putout/lib/add-traverse-args/fixture/options-fix.js

@@ -0,0 +1,9 @@
+export const report = () => `Use 'if condition' instead of 'ternary expression'`;
+
+export const fix = () => {};
+
+export const traverse = ({options}) => ({
+    Program() {
+        console.log(options.x);
+    },
+});

packages/plugin-putout/lib/add-traverse-args/fixture/options.js

@@ -0,0 +1,11 @@
+export const report = () => `Use 'if condition' instead of 'ternary expression'`;
+
+export const fix = () => {
+};
+
+export const traverse = () => ({
+    Program() {
+        console.log(options.x);
+    }
+});
+

packages/plugin-putout/lib/add-traverse-args/index.js

@@ -7,13 +7,14 @@ const {
     identifier,
 } = types;
 
-const {traverse} = operator;
+const {traverse, getBinding} = operator;
 
 const defaultNames = [
     'push',
     'store',
     'listStore',
     'pathStore',
+    'options',
 ];
 
 module.exports.report = ({name}) => `Add '${name}' argument to 'traverse'`;
@@ -73,22 +74,23 @@ const checkArgs = (names, push) => (path) => {
             if (isArgExists(name, fn))
                 return;
 
+            if (getBinding(path, name))
+                return;
+            
             push({
                 path,
                 fn,
                 name,
             });
         },
-        [`__a(__args)`]: (currentPath) => {
-            const {callee} = currentPath.node;
+        [`__a(__args)`]: (path) => {
+            const {callee} = path.node;
             const {name} = callee;
 
             if (!names.includes(name))
                 return;
 
-            const bindings = currentPath.scope.getAllBindings();
-            
-            if (bindings[name])
+            if (getBinding(path, name))
                 return;
 
             push({

packages/plugin-putout/lib/add-traverse-args/index.spec.js

@@ -53,3 +53,13 @@ test('plugin-putout: add-traverse-args: transform: list-store', (t) => {
     t.transform('list-store');
     t.end();
 });
+
+test('plugin-putout: add-traverse-args: transform: options', (t) => {
+    t.transform('options');
+    t.end();
+});
+
+test('plugin-putout: add-traverse-args: no report: options-declared-upper', (t) => {
+    t.noReport('options-declared-upper');
+    t.end();
+});