feature: @putout/plugin-apply-destructuring: convert-object-to-array: add

Author: coderaiser

packages/plugin-apply-destructuring/README.md

@@ -20,6 +20,7 @@ npm i @putout/plugin-apply-destructuring
 - ✅ [object](#object);
 - ✅ [array](#array);
 - ✅ [falsy](#falsy);
+- ✅ [convert-object-to-array](#convert-object-to-array);
 
 ## Config
 
@@ -95,6 +96,22 @@ const {maxElementsInOneLine} = {
 const {maxElementsInOneLine} = options;
 ```
 
+## convert-object-to-array
+
+Check out in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/a1d26daf8bb83ee3ea1c0b62a6ad3afd/cef9b4d27c9dbb0d413a935b0359a6fe9b50364f).
+
+## ❌ Example of incorrect code
+
+```js
+const {0: a, 1: b} = c;
+```
+
+## ✅ Example of correct code
+
+```js
+const [a, b] = c;
+```
+
 ## License
 
 MIT

packages/plugin-apply-destructuring/lib/convert-object-to-array/fixture/convert-object-to-array-fix.js

@@ -0,0 +1,3 @@
+const [a, b] = c;
+
+const {...x} = c;

packages/plugin-apply-destructuring/lib/convert-object-to-array/fixture/convert-object-to-array.js

@@ -0,0 +1,3 @@
+const {0: a, 1: b} = c;
+
+const {...x} = c;

packages/plugin-apply-destructuring/lib/convert-object-to-array/fixture/no-indexes.js

@@ -0,0 +1 @@
+module.exports = ({rule, plugin, msg, options}, {}) => {};

packages/plugin-apply-destructuring/lib/convert-object-to-array/index.js

@@ -0,0 +1,41 @@
+import {types, operator} from 'putout';
+
+const {replaceWith} = operator;
+const {
+    isObjectProperty,
+    arrayPattern,
+} = types;
+
+export const report = () => `Use array destructuring instead of object destructuring`;
+
+export const fix = (path) => {
+    const elements = [];
+    
+    for (const {value} of path.node.properties) {
+        elements.push(value);
+    }
+    
+    const array = arrayPattern(elements);
+    replaceWith(path, array);
+};
+
+export const traverse = ({push}) => ({
+    ObjectPattern(path) {
+        const properties = path.get('properties');
+        
+        if (!properties.length)
+            return;
+        
+        for (const [i, prop] of properties.entries()) {
+            if (!isObjectProperty(prop))
+                return;
+            
+            const {key} = prop.node;
+            
+            if (i !== key.value)
+                return;
+        }
+        
+        push(path);
+    },
+});

packages/plugin-apply-destructuring/lib/convert-object-to-array/index.spec.js

@@ -0,0 +1,23 @@
+import {createTest} from '@putout/test';
+import * as plugin from './index.js';
+
+const test = createTest(import.meta.url, {
+    plugins: [
+        ['convert-object-to-array', plugin],
+    ],
+});
+
+test('apply-destructuring: convert-object-to-array: report', (t) => {
+    t.report('convert-object-to-array', `Use array destructuring instead of object destructuring`);
+    t.end();
+});
+
+test('apply-destructuring: convert-object-to-array: transform', (t) => {
+    t.transform('convert-object-to-array');
+    t.end();
+});
+
+test('apply-destructuring: convert-object-to-array: no report: no-indexes', (t) => {
+    t.noReport('no-indexes');
+    t.end();
+});

packages/plugin-apply-destructuring/lib/index.js

@@ -1,3 +1,4 @@
+import * as convertObjectToArray from './convert-object-to-array/index.js';
 import * as object from './object/index.js';
 import * as array from './array/index.js';
 import * as falsy from './falsy/index.js';
@@ -6,4 +7,5 @@ export const rules = {
     object,
     array,
     falsy,
+    'convert-object-to-array': convertObjectToArray,
 };

packages/plugin-apply-destructuring/test/apply-destructuring.js

@@ -51,3 +51,8 @@ test('plugin-apply-destructuring: transform: falsy', (t) => {
     t.transform('falsy');
     t.end();
 });
+
+test('plugin-apply-destructuring: transform: convert-object-to-array', (t) => {
+    t.transform('convert-object-to-array');
+    t.end();
+});

packages/plugin-apply-destructuring/test/fixture/convert-object-to-array-fix.js

@@ -0,0 +1,3 @@
+const [a, b] = c;
+
+const {...x} = c;

packages/plugin-apply-destructuring/test/fixture/convert-object-to-array.js

@@ -0,0 +1,3 @@
+const {0: a, 1: b} = c;
+
+const {...x} = c;