feature: remove-unused-variables: ExportNamedDeclaraiton: ObjectPattern

Author: coderaiser

packages/plugin-remove-unused-variables/lib/get-vars/get-vars.js

@@ -13,8 +13,9 @@ const {
     traverseTemplateLiteral,
 } = require('./traverse');
 
-const {isKeyword} = operator;
+const {createExportNamedDeclaration} = require('./visitors/export-named-declaration.js');
 const {assign} = Object;
+const {isKeyword} = operator;
 
 const {
     isAssignmentPattern,
@@ -25,8 +26,6 @@ const {
     isObjectExpression,
     isFunctionDeclaration,
     isArrayExpression,
-    isArrayPattern,
-    isVariableDeclaration,
     isRestElement,
 } = types;
 
@@ -513,49 +512,9 @@ module.exports = ({use, declare, addParams}) => {
             if (isObjectExpression(declaration))
                 return traverseObj(declarationPath.get('properties'));
         },
-        
-        ExportNamedDeclaration(path) {
-            const declarationPath = path.get('declaration');
-            const {declaration, specifiers} = path.node;
-            
-            if (declarationPath.isFunctionDeclaration())
-                return use(path, declaration.id.name);
-            
-            if (declarationPath.isClassDeclaration())
-                return use(path, declaration.id.name);
-            
-            // typescript
-            if (declarationPath.isTSInterfaceDeclaration())
-                return use(path, declaration.id.name);
-            
-            if (declarationPath.isTSTypeAliasDeclaration())
-                return use(path, declaration.id.name);
-            
-            if (isVariableDeclaration(declaration)) {
-                const {declarations} = declaration;
-                
-                for (const {id} of declarations) {
-                    /* istanbul ignore else */
-                    if (isIdentifier(id))
-                        use(path, id.name);
-                    
-                    if (isArrayPattern(id))
-                        for (const element of id.elements) {
-                            if (isIdentifier(element))
-                                use(path, element.name);
-                        }
-                }
-                
-                return;
-            }
-            
-            for (const {local} of specifiers) {
-                /* istanbul ignore else */
-                if (isIdentifier(local))
-                    use(path, local.name);
-            }
-        },
-        
+        ExportNamedDeclaration: createExportNamedDeclaration({
+            use,
+        }),
         Function(path) {
             const {node, parentPath} = path;
             const {

packages/plugin-remove-unused-variables/lib/get-vars/visitors/export-named-declaration.js

@@ -0,0 +1,62 @@
+'use strict';
+
+const {types} = require('putout');
+const {
+    isArrayPattern,
+    isRestElement,
+    isObjectPattern,
+    isIdentifier,
+    isVariableDeclaration,
+} = types;
+
+module.exports.createExportNamedDeclaration = ({use}) => (path) => {
+    const declarationPath = path.get('declaration');
+    const {declaration, specifiers} = path.node;
+    
+    if (declarationPath.isFunctionDeclaration())
+        return use(path, declaration.id.name);
+    
+    if (declarationPath.isClassDeclaration())
+        return use(path, declaration.id.name);
+    
+    // typescript
+    if (declarationPath.isTSInterfaceDeclaration())
+        return use(path, declaration.id.name);
+    
+    if (declarationPath.isTSTypeAliasDeclaration())
+        return use(path, declaration.id.name);
+    
+    if (isVariableDeclaration(declaration)) {
+        const {declarations} = declaration;
+        
+        for (const {id} of declarations) {
+            /* istanbul ignore else */
+            if (isIdentifier(id))
+                use(path, id.name);
+            
+            if (isObjectPattern(id))
+                for (const property of id.properties) {
+                    if (isRestElement(property) && isIdentifier(property.argument)) {
+                        use(path, property.argument.name);
+                        continue;
+                    }
+                    
+                    if (isIdentifier(property.value))
+                        use(path, property.value.name);
+                }
+            
+            if (isArrayPattern(id))
+                for (const element of id.elements)
+                    if (isIdentifier(element))
+                        use(path, element.name);
+        }
+        
+        return;
+    }
+    
+    for (const {local} of specifiers) {
+        /* istanbul ignore else */
+        if (isIdentifier(local))
+            use(path, local.name);
+    }
+};

packages/plugin-remove-unused-variables/test/fixture/export-const.js

@@ -0,0 +1 @@
+export const {rules, ...spread} = putout;

packages/plugin-remove-unused-variables/test/get-vars.js

@@ -36,6 +36,7 @@ const fixture = readFixtures([
     'destr-fn-vars',
     'decorator',
     'do-while',
+    'export-const',
     'export-default-function',
     'export-default-anonymous-function',
     'export-default-class',
@@ -814,6 +815,29 @@ test('remove-unused-variables: get-vars: import', (t) => {
     t.end();
 });
 
+test('remove-unused-variables: get-vars: export const', (t) => {
+    const ast = parse(fixture.exportConst);
+    const result = getVars(ast);
+    
+    const expected = [{
+        putout: {
+            declared: false,
+            used: true,
+        },
+        rules: {
+            declared: true,
+            used: true,
+        },
+        spread: {
+            declared: true,
+            used: true,
+        },
+    }];
+    
+    t.deepEqual(result, expected);
+    t.end();
+});
+
 test('remove-unused-variables: get-vars: export default function', (t) => {
     const ast = parse(fixture.exportDefaultFunction);
     const result = getVars(ast);