feature: @putout/plugin-regexp: apply-global-regexp-to-replace-all

Author: coderaiser

docs/syntax-errors.md

@@ -360,3 +360,12 @@ export const {
 ```
 
 </details>
+
+<details><summary><code>replaceAll()</code> called with a non-global <code>RegExp</code>argument</summary>
+
+```diff
+-'hello'.replaceAll(/hello/, 'world')
++'hello'.replaceAll(/hello/g, 'world')
+```
+
+</details>

packages/plugin-regexp/README.md

@@ -18,6 +18,7 @@ npm i @putout/plugin-regexp -D
 ## Rules
 
 - ✅ [apply-ends-with](#apply-ends-with);
+- ✅ [apply-global-regexp-to-replace-al](#apply-global-regexp-to-replace-all);
 - ✅ [apply-literal-notation](#apply-literal-notation);
 - ✅ [apply-starts-with](#apply-starts-with);
 - ✅ [convert-replace-to-replace-all](#convert-replace-to-replace-all);
@@ -32,6 +33,7 @@ npm i @putout/plugin-regexp -D
 ```json
 {
     "rules": {
+        "regexp/apply-global-regexp-to-replace-all": "on",
         "regexp/apply-literal-notation": "on",
         "regexp/apply-starts-with": "on",
         "regexp/apply-ends-with": "on",
@@ -58,6 +60,28 @@ const a = /(ab|ab)/;
 const a = /(ab)/;
 ```
 
+## apply-global-regexp-to-replace-all
+
+> `Uncaught TypeError: String.prototype.replaceAll called with a non-global RegExp argument`
+>
+> (c) [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Requires_global_RegExp)
+
+Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/8c759e3c8d19d660ddb01bda04d75c8b/f1d0f3a6d491f034308f5f3a375900b0a620a3b3).
+
+### ❌ Example of incorrect code
+
+```js
+'s'.replaceAll(/hello/, 's');
+'abc'.matchAll(/./);
+```
+
+### ✅ Example of correct code
+
+```js
+'s'.replaceAll(/hello/g, 's');
+'abc'.matchAll(/./g);
+```
+
 ## apply-literal-notation
 
 ### ❌ Example of incorrect code

packages/plugin-regexp/lib/apply-global-regexp-to-replace-all/fixture/apply-global-regexp-to-replace-all-fix.js

@@ -0,0 +1 @@
+'s'.replaceAll(/hello/g, 's');

packages/plugin-regexp/lib/apply-global-regexp-to-replace-all/fixture/apply-global-regexp-to-replace-all.js

@@ -0,0 +1 @@
+'s'.replaceAll(/hello/, 's')

packages/plugin-regexp/lib/apply-global-regexp-to-replace-all/fixture/match-all-fix.js

@@ -0,0 +1 @@
+'abc'.matchAll(/./g);

packages/plugin-regexp/lib/apply-global-regexp-to-replace-all/fixture/match-all.js

@@ -0,0 +1 @@
+"abc".matchAll(/./);

packages/plugin-regexp/lib/apply-global-regexp-to-replace-all/index.js

@@ -0,0 +1,20 @@
+const check = ({__a}) => !__a.raw.endsWith('g');
+const transform = ({__a}, path) => {
+    __a.raw += 'g';
+    return path;
+};
+
+export const report = (path) => {
+    const name = path.get('callee.property');
+    return `Call '${name.node.name}()' with global 'RegExp'`;
+};
+
+export const match = () => ({
+    '__.replaceAll(/__a/, __b)': check,
+    '__.matchAll(/__a/)': check,
+});
+
+export const replace = () => ({
+    '__.replaceAll(/__a/, __b)': transform,
+    '__.matchAll(/__a/)': transform,
+});

packages/plugin-regexp/lib/apply-global-regexp-to-replace-all/index.spec.js

@@ -0,0 +1,28 @@
+import {createTest} from '@putout/test';
+import * as plugin from './index.js';
+
+const test = createTest(import.meta.url, {
+    plugins: [
+        ['apply-global-regexp-to-replace-all', plugin],
+    ],
+});
+
+test('regexp: apply-global-regexp-to-replace-all: report', (t) => {
+    t.report('apply-global-regexp-to-replace-all', `Call 'replaceAll()' with global 'RegExp'`);
+    t.end();
+});
+
+test('regexp: apply-global-regexp-to-replace-all: report: match-all', (t) => {
+    t.report('match-all', `Call 'matchAll()' with global 'RegExp'`);
+    t.end();
+});
+
+test('regexp: apply-global-regexp-to-replace-all: transform', (t) => {
+    t.transform('apply-global-regexp-to-replace-all');
+    t.end();
+});
+
+test('regexp: apply-global-regexp-to-replace-all: transform: match-all', (t) => {
+    t.transform('match-all');
+    t.end();
+});

packages/plugin-regexp/lib/index.js

@@ -1,3 +1,4 @@
+import * as applyGlobalRegexpToReplaceAll from './apply-global-regexp-to-replace-all/index.js';
 import * as applyLiteralNotation from './apply-literal-notation/index.js';
 import * as applyStartsWith from './apply-starts-with/index.js';
 import * as applyEndsWith from './apply-ends-with/index.js';
@@ -16,4 +17,5 @@ export const rules = {
     'convert-replace-to-replace-all': convertReplaceToReplaceAll,
     'remove-useless-group': removeUselessGroup,
     'remove-useless-regexp': removeUselessRegexp,
+    'apply-global-regexp-to-replace-all': applyGlobalRegexpToReplaceAll,
 };

packages/plugin-regexp/test/fixture/apply-global-regexp-to-replace-all-fix.js

@@ -0,0 +1 @@
+'s'.replaceAll(/hello/g, 's');