fix: @putout/plugin-minify: convert-let-to-var-inside-label -> convert-l

Author: coderaiser

packages/plugin-minify/.putout.json

@@ -4,7 +4,8 @@
             "split-variable-declarations": "off",
             "assignment/split": "off",
             "convert-template-to-string": "off",
-            "conditions/convert-equal-to-strict-equal": "off"
+            "conditions/convert-equal-to-strict-equal": "off",
+            "conditions/evaluate": "off"
         }
     }
 }

packages/plugin-minify/README.md

@@ -17,7 +17,7 @@ npm i @putout/plugin-putout -D
 - ✅ [apply-ternary](#apply-ternary);
 - ✅ [convert-array-from-to-spread](#convert-array-from-to-spread);
 - ✅ [convert-const-to-let](#convert-const-to-let);
-- ✅ [convert-let-to-var-inside-label](#convert-let-to-var-inside-label);
+- ✅ [convert-let-to-var](#convert-let-to-var);
 - ✅ [convert-if-to-logical](#convert-if-to-logical);
 - ✅ [convert-return-to-sequence-expression](#convert-return-to-sequence-expression);
 - ✅ [convert-strict-equal-to-equal](#convert-strict-equal-to-equal);
@@ -43,7 +43,7 @@ npm i @putout/plugin-putout -D
         "minify/apply-ternary": "on",
         "minify/apply-template-literal": "on",
         "minify/convert-const-to-let": "on",
-        "minify/convert-let-to-var-inside-label": "on",
+        "minify/convert-let-to-var": "on",
         "minify/convert-if-to-logical": "on",
         "minify/convert-strict-equal-to-equal": "on",
         "minify/convert-array-from-to-spread": "on",
@@ -165,24 +165,30 @@ const a = 5;
 let a = 5;
 ```
 
-## convert-let-to-var-inside-label
+## convert-let-to-var
 
 > `Lexical declaration cannot appear in a single-statement context`
 >
 > (c) [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements#difference_between_statements_and_declarations)
 
-Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/b92716be2c378e440e0ba963bb284803/da777584a3382012787a8216e089f6bc84b98abe).
+Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/269edbd94999bc2ca919de7326a2c0fc/665350212e082c26d282e181da8506904322fd1b).
 
 ### ❌ Example of incorrect code
 
 ```
 javascript: let a = 3;
+
+if (5)
+    let b = 3;
 ```
 
 ### ✅ Example of correct code
 
 ```js
 javascript: var a = 3;
+
+if (5)
+    var b = 3;
 ```
 
 ## convert-return-to-sequence-expression

packages/plugin-minify/lib/convert-let-to-var-inside-label/fixture/convert-let-to-var-inside-label-fix.js

@@ -0,0 +1,2 @@
+javascript: var a = 3;if (a)
+    var b = 3;

packages/plugin-minify/lib/convert-let-to-var-inside-label/index.spec.js

@@ -1 +1,4 @@
 javascript: let a = 3;
+
+if (a)
+    let b = 3;

packages/plugin-minify/lib/convert-let-to-var/fixture/convert-let-to-var-fix.js

@@ -1,12 +1,18 @@
 import {types} from 'putout';
 
-const {isLabeledStatement} = types;
+const {
+    isIfStatement,
+    isLabeledStatement,
+} = types;
 
 export const report = () => `Use 'var' instead of 'let' inside label`;
 
 export const match = () => ({
     'let __b = __c': (vars, path) => {
-        return isLabeledStatement(path.parentPath);
+        if (isLabeledStatement(path.parentPath))
+            return true;
+        
+        return isIfStatement(path.parentPath);
     },
 });
 

…xture/convert-let-to-var-inside-label.js …let-to-var/fixture/convert-let-to-var.jspackages/plugin-minify/test/fixture/convert-let-to-var-inside-label.js renamed to packages/plugin-minify/lib/convert-let-to-var/fixture/convert-let-to-var.js packages/plugin-minify/test/fixture/convert-let-to-var-inside-label.js renamed to packages/plugin-minify/lib/convert-let-to-var/fixture/convert-let-to-var.js

@@ -0,0 +1,18 @@
+import {createTest} from '@putout/test';
+import * as plugin from './index.js';
+
+const test = createTest(import.meta.url, {
+    plugins: [
+        ['convert-let-to-var', plugin],
+    ],
+});
+
+test('minify: convert-let-to-var: report', (t) => {
+    t.report('convert-let-to-var', `Use 'var' instead of 'let' inside label`);
+    t.end();
+});
+
+test('minify: convert-let-to-var: transform', (t) => {
+    t.transform('convert-let-to-var');
+    t.end();
+});

…convert-let-to-var-inside-label/index.js …n-minify/lib/convert-let-to-var/index.jspackages/plugin-minify/lib/convert-let-to-var-inside-label/index.js renamed to packages/plugin-minify/lib/convert-let-to-var/index.js packages/plugin-minify/lib/convert-let-to-var-inside-label/index.js renamed to packages/plugin-minify/lib/convert-let-to-var/index.js

@@ -1,4 +1,4 @@
-import * as convertLetToVarInsideLabel from './convert-let-to-var-inside-label/index.js';
+import * as convertLetToVar from './convert-let-to-var/index.js';
 import * as applyTernary from './apply-ternary/index.js';
 import * as applyTemplateLiteral from './apply-template-literal/index.js';
 import * as convertConstToLet from './convert-const-to-let/index.js';
@@ -39,5 +39,5 @@ export const rules = {
     'join-continued-strings': joinContinuedStrings,
     'convert-return-to-sequence-expression': convertReturnToSequenceExpression,
     'merge-assignment-expressions': mergeAssignmentExpressions,
-    'convert-let-to-var-inside-label': convertLetToVarInsideLabel,
+    'convert-let-to-var': convertLetToVar,
 };

packages/plugin-minify/lib/convert-let-to-var/index.spec.js

@@ -0,0 +1,2 @@
+javascript: var a = 3;if (a)
+    var b = 3;