feature: @putout/plugin-remove-unused-private-fields: use before declare

Author: coderaiser

packages/plugin-remove-unused-private-fields/lib/remove-unused-private-fields.js

@@ -4,12 +4,13 @@ const {traverse, operator} = require('putout');
 
 const {remove} = operator;
 
-module.exports.report = ({name}) => `private field "#${name}" declared by not used`;
+module.exports.report = ({name}) => `Private field "#${name}" declared by not used`;
 
 module.exports.find = (ast) => {
     const vars = [];
     const addVar = addVariable(vars);
     const rmVar = removeVariable(vars);
+    const list = [];
 
     traverseClass(ast, {
         ClassPrivateProperty(path) {
@@ -27,7 +28,7 @@ module.exports.find = (ast) => {
             const propertyPath = parentPath.get('property');
 
             if (propertyPath.isPrivateName()) {
-                rmVar(path, propertyPath.node.id.name);
+                list.push([path, propertyPath.node.id.name]);
                 return;
             }
 
@@ -43,11 +44,15 @@ module.exports.find = (ast) => {
                 const keyPath = propertyPath.get('key');
 
                 if (keyPath.isPrivateName())
-                    rmVar(path, keyPath.node.id.name);
+                    list.push([path, keyPath.node.id.name]);
             }
         },
     });
 
+    for (const [path, name] of list) {
+        rmVar(path, name);
+    }
+    
     return Object.values(vars);
 };
 

packages/plugin-remove-unused-private-fields/test/fixture/private.ts

@@ -0,0 +1,16 @@
+export class DrawCircle {
+  constructor(
+    el: HTMLElement,
+    radius: number,
+    options: SpeccerOptionsInterface
+  ) {
+    this.#init(el, radius, options);
+  }
+
+  #init(el: HTMLElement, radius: number, options: SpeccerOptionsInterface) {
+    if (!el || !radius || !options) {
+      throw new Error('Missing inputs el or radius or options');
+    }
+  }
+}
+

packages/plugin-remove-unused-private-fields/test/remove-unused-private-fields.js

@@ -10,7 +10,7 @@ const test = createTest(__dirname, {
 });
 
 test('plugin-remove-unused-private-fields: report: class', (t) => {
-    t.report('class', 'private field "#world" declared by not used');
+    t.report('class', 'Private field "#world" declared by not used');
     t.end();
 });
 
@@ -38,3 +38,8 @@ test('plugin-remove-unused-private-fields: no transform: destructuring', (t) =>
     t.noTransform('destructuring');
     t.end();
 });
+
+test('plugin-remove-unused-private-fields: no report: private', (t) => {
+    t.noReport('private');
+    t.end();
+});