feature: @putout/plugin-split-assignment-expressions: array destructuring after variable assignment

Author: coderaiser

packages/plugin-split-assignment-expressions/lib/split-assignment-expressions.js

@@ -5,13 +5,29 @@ const {replaceWithMultiple} = operator;
 const {
     isAssignmentExpression,
     AssignmentExpression,
+    ArrayPattern,
     isMemberExpression,
     isSequenceExpression,
 } = types;
 
 module.exports.report = () => `Split assignment expressions`;
 
-module.exports.fix = ({path, lefts, right}) => {
+module.exports.fix = ({path, lefts, right, merged}) => {
+    if (merged) {
+        const rightPath = path.get('right');
+        const {right, left} = rightPath.node;
+        const {object, property} = left;
+        
+        const assignments = [
+            AssignmentExpression(lefts[0][0], lefts[0][1], object),
+            AssignmentExpression(lefts[1][0], convertToArray(property), right),
+        ];
+        
+        replaceWithMultiple(path, assignments);
+        
+        return;
+    }
+    
     const [[operator, firstLeft], ...otherLefts] = lefts;
     const assignments = [
         AssignmentExpression(operator, firstLeft, right),
@@ -37,8 +53,7 @@ module.exports.traverse = ({push}) => ({
         if (!isAssignmentExpression(right))
             return;
 
-        if (isMemberExpression(right.left) && isSequenceExpression(right.left.property))
-            return;
+        const merged = isMemberExpression(right.left) && isSequenceExpression(right.left.property);
 
         const lefts = [
             [operator, left],
@@ -57,6 +72,9 @@ module.exports.traverse = ({push}) => ({
             path,
             lefts,
             right,
+            merged,
         });
     },
 });
+
+const convertToArray = ({expressions}) => ArrayPattern(expressions);

packages/plugin-split-assignment-expressions/test/fixture/separate-fix.js

@@ -0,0 +1,2 @@
+currentDir = dirname(currentDir);
+[currentDir, currentType] = getParentPath(currentDir, filesystem);

packages/plugin-split-assignment-expressions/test/split-assignment-expressions.js

@@ -29,7 +29,7 @@ test('putout: split-assignment-expressions: transform', (t) => {
     t.end();
 });
 
-test('putout: split-assignment-expressions: no report: separate', (t) => {
-    t.noReport('separate');
+test('putout: split-assignment-expressions: transform: separate', (t) => {
+    t.transform('separate');
     t.end();
 });