fix: @putout/plugin-apply-arrow: find top scope

Author: coderaiser

packages/plugin-apply-arrow/lib/apply-arrow.js

@@ -1,6 +1,8 @@
 'use strict';
 
-const {print} = require('putout');
+const {print, types} = require('putout');
+const {isFunction, isProgram} = types;
+const isTopScope = (a) => isFunction(a) || isProgram(a);
 
 module.exports.report = () => `Use 'Arrow Function' instead of 'Function Declaration`;
 
@@ -19,8 +21,9 @@ module.exports.match = () => ({
             return binding.references === 1;
 
         const [ref] = binding.referencePaths;
+        const {uid} = ref.find(isTopScope).scope;
 
-        return ref.scope.uid !== binding.scope.uid;
+        return uid !== binding.scope.uid;
     },
 });
 

packages/plugin-apply-arrow/test/apply-arrow.js

@@ -32,6 +32,11 @@ test('putout: apply-arrow: no report: long', (t) => {
     t.end();
 });
 
+test('putout: apply-arrow: no report: for-of', (t) => {
+    t.noReport('for-of');
+    t.end();
+});
+
 test('putout: apply-arrow: no report: no-loc', (t) => {
     const FN = 'function __a(__args) {return __b}';
 

packages/plugin-apply-arrow/test/fixture/for-of.js

@@ -0,0 +1,21 @@
+for (const name of names) {
+    console.log(run(plugin, name));
+}
+
+function run(plugin, rule) {
+    return montag`
+        "${plugin}/${rule}": {
+            "$ref": "#/definitions/rule"
+        },
+    `;
+}
+
+function x() {
+    for (const name of names) {
+        b();
+    }
+
+    function b() {
+        return c;
+    }
+}

scripts/generate-schema.js

@@ -2,6 +2,12 @@ import {readdir} from 'node:fs/promises';
 import process from 'node:process';
 import montag from 'montag';
 
+const run = (plugin, rule) => montag`
+    "${plugin}/${rule}": {
+        "$ref": "#/definitions/rule"
+    },
+`;
+
 const [plugin] = process.argv.slice(2);
 
 if (!plugin) {
@@ -15,8 +21,3 @@ for (const name of names) {
     console.log(run(plugin, name));
 }
 
-const run = (plugin, rule) => montag`
-    "${plugin}/${rule}": {
-        "$ref": "#/definitions/rule"
-    },
-`;