feature: @putout/processor-wasm: rules: remove-useless-args: add

Author: coderaiser

packages/processor-wasm/README.md

@@ -73,6 +73,21 @@ npm i @putout/processor-wasm -D
 
 ### remove-unused
 
+```diff
+(module
+    (func $one (result i32)
+        i32.const 1
+    )
+    (func $oneTwo (param $y) (result i32 i32)
+-       (call $one (local.get $y))
++       (call $one)
+        i32.const 2
+    )
+)
+```
+
+### remove-useless-args
+
 ```diff
 (module
 -   (func $answer (result i32)

packages/processor-wasm/lib/lint.js

@@ -83,11 +83,18 @@ const parseError = ({message}) => ({
     },
 });
 
+const parsePath = (path) => path.path || path;
+
 function convertPlaces(rule, rawPlaces, plugin) {
     const places = [];
 
     for (const path of rawPlaces) {
-        const {line, column} = path.node.loc.start;
+        const currentPath = parsePath(path);
+        
+        const {line, column} = currentPath.node.loc?.start || {
+            line: 0,
+            column: 0,
+        };
 
         places.push({
             rule: `${rule} (wasm)`,

packages/processor-wasm/lib/rules/index.js

@@ -1,9 +1,13 @@
 import * as convertGetLocalToLocalGet from './convert-get-local-to-local-get/index.js';
 import * as convertSetLocalToLocalSet from './convert-set-local-to-local-set/index.js';
 import * as applyNesting from './apply-nesting/index.js';
+import * as removeUselessArgs from './remove-useless-args/index.js';
+import * as removeUnused from './remove-unused/index.js';
 
 export const rules = [
     ['convert-get-local-to-local-get', convertGetLocalToLocalGet],
     ['convert-set-local-to-local-set', convertSetLocalToLocalSet],
     ['apply-nesting', applyNesting],
+    ['remove-useless-args', removeUselessArgs],
+    ['remove-unused', removeUnused],
 ];

packages/processor-wasm/lib/rules/remove-useless-args/fixture/remove-useless-args-fix.wast

@@ -0,0 +1,9 @@
+(module
+  (func $one (result i32)
+    (i32.const 1)
+  )
+  (func $oneTwo (result i32) (result i32)
+    (call $one)
+    (i32.const 2)
+  )
+)

packages/processor-wasm/lib/rules/remove-useless-args/fixture/remove-useless-args.wast

@@ -0,0 +1,9 @@
+(module
+    (func $one (result i32)
+        i32.const 1
+    )
+    (func $oneTwo (param $y) (result i32 i32)
+        (call $one (local.get $y))
+        i32.const 2
+    )
+)

packages/processor-wasm/lib/rules/remove-useless-args/index.js

@@ -0,0 +1,37 @@
+const {entries} = Object;
+
+export const report = ({path}) => `Avoid useless arguments in '${path.node.index.value}' call`;
+
+export const fix = ({path, length}) => {
+    path.node.instrArgs.length = length;
+};
+
+export const find = (ast, {push, traverse}) => {
+    const funcs = {};
+    const calls = {};
+    
+    traverse(ast, {
+        Func(path) {
+            const {value} = path.node.name;
+            const {params} = path.node.signature;
+            
+            funcs[value] = params;
+        },
+        CallInstruction(path) {
+            const {index, instrArgs} = path.node;
+            const {value} = index;
+            
+            calls[value] = [path, instrArgs];
+        },
+    });
+    
+    for (const [name, [path, args]] of entries(calls)) {
+        const {length} = funcs[name];
+        
+        if (length < args.length)
+            push({
+                path,
+                length,
+            });
+    }
+};

packages/processor-wasm/lib/rules/remove-useless-args/index.spec.js

@@ -0,0 +1,18 @@
+import {createTest} from '#test';
+import * as plugin from './index.js';
+
+const test = createTest(import.meta.url, {
+    plugins: [
+        ['remove-useless-args', plugin],
+    ],
+});
+
+test('putout: processor-wasm: remove-useless-args: report', (t) => {
+    t.report('remove-useless-args', `Avoid useless arguments in 'one' call`);
+    t.end();
+});
+
+test('putout: processor-wasm: remove-useless-args: transform', (t) => {
+    t.transform('remove-useless-args');
+    t.end();
+});

packages/processor-wasm/test/fixture/apply-nesting-fix.wast

@@ -1,9 +1,6 @@
 (module
   ;; this is simple function that adds a couple of parameters
 
-  (func (param $a i32) (param $b i32)
-    (i32.add (get.local $b) (get.local $a))
-  )
   ;; this statement exports the function to the host environment
 
   (export "add" (func $add))

packages/processor-wasm/test/fixture/remove-unused-fix.wast

@@ -0,0 +1,2 @@
+(module
+)

packages/processor-wasm/test/fixture/remove-unused.wast

@@ -0,0 +1,5 @@
+(module
+    (func $answer (result i32)
+        i32.const 0x2A
+    )
+)