feature(readify) drop support of node < 10

Author: coderaiser

.eslintrc.json

@@ -1,4 +1,7 @@
 {
+    "rules": {
+        "node/no-unsupported-features/node-builtins": "off"
+    },
     "extends": [
         "plugin:putout/recommended",
         "plugin:node/recommended"

lib/readdir.js

@@ -1,14 +1,12 @@
 'use strict';
 
 const {join} = require('path');
-const {promisify} = require('util');
-const fs = require('fs');
+const {readdir} = require('fs').promises;
 
 const tryToCatch = require('try-to-catch');
 const superstat = require('superstat');
 
 const noop = function() {};
-const readdir = promisify(fs.readdir);
 
 const {assign} = Object;
 

lib/readify.js

@@ -33,7 +33,7 @@ async function readify(path, options = {}) {
     const sorted = sortify({sort, order}, names);
     const formated = ifRaw(type, formatify, sorted);
 
-    return fillJSON(path, type, formated);
+    return await fillJSON(path, type, formated);
 }
 
 function check(path, type) {

madrun.js

@@ -4,7 +4,7 @@ const {run} = require('madrun');
 
 module.exports = {
     'lint': () => 'putout lib test madrun.js',
-    'fix:lint': () => run(['putout', 'lint:*'], '--fix'),
+    'fix:lint': () => run('lint', '--fix'),
     'report': () => 'nyc report --reporter=text-lcov | coveralls',
     'coverage': () => 'nyc npm test',
     'test': () => 'tape test/*.js',

package.json

@@ -15,11 +15,8 @@
     ]
   },
   "scripts": {
-    "putout": "madrun putout",
     "lint": "madrun lint",
     "fix:lint": "madrun fix:lint",
-    "lint:eslint:lib": "madrun lint:eslint:lib",
-    "lint:eslint:test": "madrun lint:eslint:test",
     "report": "madrun report",
     "coverage": "madrun coverage",
     "test": "madrun test",
@@ -52,7 +49,7 @@
   "license": "MIT",
   "main": "lib/readify.js",
   "engines": {
-    "node": ">=8.3.0"
+    "node": ">=10"
   },
   "devDependencies": {
     "@cloudcmd/stub": "^2.0.0",

test/readdir.js

@@ -1,7 +1,6 @@
 'use strict';
 
 const fs = require('fs');
-const {callbackify} = require('util');
 
 const stub = require('@cloudcmd/stub');
 const test = require('supertape');
@@ -12,35 +11,35 @@ const tryToCatch = require('try-to-catch');
 const noop = () => {};
 
 test('readdir: empty dir', async (t) => {
-    const {readdir} = fs;
-    fs.readdir = callbackify(async () => []);
+    const {readdir} = fs.promises;
+    fs.promises.readdir = async () => [];
 
     const _readdir = reRequire('../lib/readdir');
 
     const [, result] = await tryToCatch(_readdir, '.');
 
-    fs.readdir = readdir;
+    fs.promises.readdir = readdir;
 
     t.deepEqual(result, [], 'should return empty array');
     t.end();
 });
 
 test('readdir: empty stat', async (t) => {
-    const {readdir} = fs;
+    const {readdir} = fs.promises;
 
     mockRequire('superstat', async () => {
         throw Error('some');
     });
 
-    fs.readdir = callbackify(async () => [
+    fs.promises.readdir = async () => [
         'hello',
-    ]);
+    ];
 
     const _readdir = reRequire('../lib/readdir');
 
     const [, result] = await tryToCatch(_readdir, '/');
 
-    fs.readdir = readdir;
+    fs.promises.readdir = readdir;
 
     const expected = [{
         name: 'hello',
@@ -58,17 +57,15 @@ test('readdir: empty stat', async (t) => {
 });
 
 test('readdir: result', async (t) => {
-    const {readdir} = fs;
+    const {readdir} = fs.promises;
 
     const name = 'hello.txt';
     const mode = 16893;
     const size = 1024;
     const mtime = new Date();
     const uid = 1000;
 
-    fs.readdir = (dir, fn) => {
-        fn(null, [name]);
-    };
+    fs.promises.readdir = async () => [name];
 
     mockRequire('superstat', async () => ({
         isDirectory: noop,
@@ -92,25 +89,23 @@ test('readdir: result', async (t) => {
     const _readdir = reRequire('../lib/readdir');
     const [, result] = await tryToCatch(_readdir, '.');
 
-    fs.readdir = readdir;
+    fs.promises.readdir = readdir;
     stopAll();
 
     t.deepEqual(result, expected, 'should get raw values');
     t.end();
 });
 
 test('readdir: result: no error', async (t) => {
-    const {readdir} = fs;
+    const {readdir} = fs.promises;
 
     const name = 'hello.txt';
     const mode = 16893;
     const size = 1024;
     const mtime = new Date();
     const uid = 1000;
 
-    fs.readdir = (dir, fn) => {
-        fn(null, [name]);
-    };
+    fs.promises.readdir = () => [name];
 
     mockRequire('superstat', async () => ({
         isDirectory: noop,
@@ -126,24 +121,22 @@ test('readdir: result: no error', async (t) => {
     const [e] = await tryToCatch(_readdir, '.');
 
     stopAll();
-    fs.readdir = readdir;
+    fs.promises.readdir = readdir;
 
     t.notOk(e, e && e.message || 'should not receive error');
     t.end();
 });
 
 test('readdir: result: directory link', async (t) => {
-    const {readdir} = fs;
+    const {readdir} = fs.promises;
 
     const name = 'hello';
     const mode = 16893;
     const size = 1024;
     const mtime = new Date();
     const uid = 1000;
 
-    fs.readdir = (dir, fn) => {
-        fn(null, [name]);
-    };
+    fs.promises.readdir = () => [name];
 
     const info = {
         isDirectory: stub().returns(true),
@@ -171,25 +164,23 @@ test('readdir: result: directory link', async (t) => {
     const _readdir = reRequire('../lib/readdir');
     const [, result] = await tryToCatch(_readdir, '.');
 
-    fs.readdir = readdir;
+    fs.promises.readdir = readdir;
     stopAll();
 
     t.deepEqual(result, expected, 'should get raw values');
     t.end();
 });
 
 test('readdir: result: directory link: no error', async (t) => {
-    const {readdir} = fs;
+    const {readdir} = fs.promises;
 
     const name = 'hello';
     const mode = 16893;
     const size = 1024;
     const mtime = new Date();
     const uid = 1000;
 
-    fs.readdir = (dir, fn) => {
-        fn(null, [name]);
-    };
+    fs.promises.readdir = () => [name];
 
     mockRequire('superstat', async () => ({
         isDirectory: stub.returns(true),
@@ -205,7 +196,7 @@ test('readdir: result: directory link: no error', async (t) => {
     const [e] = await tryToCatch(_readdir, '.');
 
     stopAll();
-    fs.readdir = readdir;
+    fs.promises.readdir = readdir;
 
     t.notOk(e, e && e.message || 'should not receive error');
     t.end();