Skip to content

Commit 2c2b21b

Browse files
committed
🚀 More permissions and webhook settings.
1 parent 213f5b8 commit 2c2b21b

File tree

4 files changed

+34
-3
lines changed

4 files changed

+34
-3
lines changed

‎config/rbac/role.yaml

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,31 @@ metadata:
66
creationTimestamp: null
77
name: manager-role
88
rules:
9+
- resources:
10+
- pods
11+
verbs:
12+
- get
13+
- list
14+
- watch
15+
- apiGroups:
16+
- apps
17+
resources:
18+
- daemonsets
19+
- deplyoments
20+
- replicasets
21+
- statfulsets
22+
verbs:
23+
- get
24+
- list
25+
- watch
26+
- apiGroups:
27+
- batch
28+
resources:
29+
- cronjobs
30+
verbs:
31+
- get
32+
- list
33+
- watch
934
- apiGroups:
1035
- batch
1136
resources:

‎config/webhook/manifests.yaml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11

22
---
3-
apiVersion: admissionregistration.k8s.io/v1beta1
3+
apiVersion: admissionregistration.k8s.io/v1
44
kind: MutatingWebhookConfiguration
55
metadata:
66
creationTimestamp: null
77
name: mutating-webhook-configuration
88
webhooks:
9-
- clientConfig:
9+
- admissionReviewVersions:
10+
- v1beta1
11+
clientConfig:
1012
caBundle: Cg==
1113
service:
1214
name: webhook-service
@@ -24,3 +26,4 @@ webhooks:
2426
- UPDATE
2527
resources:
2628
- pods
29+
sideEffects: None

‎controllers/migrator.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ import (
2727
// +kubebuilder:rbac:groups=migrations.coderanger.net,resources=migrators,verbs=get;list;watch;create;update;patch;delete
2828
// +kubebuilder:rbac:groups=migrations.coderanger.net,resources=migrators/status,verbs=get;update;patch
2929
// +kubebuilder:rbac:groups=batch,resources=jobs,verbs=get;list;watch;create;update;patch
30+
// +kubebuilder:rbac:groups=,resources=pods,verbs=get;list;watch
31+
// +kubebuilder:rbac:groups=apps,resources=replicasets;deplyoments;statfulsets;daemonsets,verbs=get;list;watch
32+
// +kubebuilder:rbac:groups=batch,resources=cronjobs,verbs=get;list;watch
3033

3134
func Migrator(mgr ctrl.Manager) error {
3235
return cu.NewReconciler(mgr).

‎webhook/webhook.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import (
3737
const REQUIRE_MIGRATOR_ANNOTATION = "migrations.coderanger.net/required"
3838
const NOWAIT_MIGRATOR_ANNOTATION = "migrations.coderanger.net/no-wait"
3939

40-
// +kubebuilder:webhook:path=/mutate-v1-pod,mutating=true,failurePolicy=fail,groups="",resources=pods,verbs=create;update,versions=v1,name=mpod.migrations.coderanger.net
40+
// +kubebuilder:webhook:path=/mutate-v1-pod,mutating=true,failurePolicy=fail,sideEffects=None,groups="",resources=pods,verbs=create;update,versions=v1,name=mpod.migrations.coderanger.net
4141

4242
// initInjector injects migration initContainers into Pods
4343
type initInjector struct {

0 commit comments

Comments
 (0)