🚑 Don't closure over the loop variable.

coderanger · coderanger · commit 549e12c8c99f · 2020-12-03T01:50:27.000-08:00
diff --git a/utils/utils.go b/utils/utils.go
@@ -43,7 +43,8 @@ func ListMatchingMigrators(ctx context.Context, c client.Client, pod metav1.Obje
 			continue
 		}
 		if selector.Matches(podLabels) {
-			migrators = append(migrators, &m)
+			migrator := m
+			migrators = append(migrators, &migrator)
 		}
 	}
 	return migrators, nil

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,8 @@ func ListMatchingMigrators(ctx context.Context, c client.Client, pod metav1.Obje`
`43`	`43`	`continue`
`44`	`44`	`}`
`45`	`45`	`if selector.Matches(podLabels) {`
`46`		`- migrators = append(migrators, &m)`
	`46`	`+ migrator := m`
	`47`	`+ migrators = append(migrators, &migrator)`
`47`	`48`	`}`
`48`	`49`	`}`
`49`	`50`	`return migrators, nil`