Skip to content

Commit 0f5586e

Browse files
authored
Merge pull request containerd#9748 from fuweid/upgrade-testcase
test: update upgrade test suite in integration
2 parents dc88cde + c86c8a1 commit 0f5586e

File tree

6 files changed

+401
-164
lines changed

6 files changed

+401
-164
lines changed

integration/cri-api/pkg/apis/services.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ type RuntimeService interface {
120120
// UpdateRuntimeConfig updates runtime configuration if specified
121121
UpdateRuntimeConfig(runtimeConfig *runtimeapi.RuntimeConfig, opts ...grpc.CallOption) error
122122
// Status returns the status of the runtime.
123-
Status(opts ...grpc.CallOption) (*runtimeapi.RuntimeStatus, error)
123+
Status(opts ...grpc.CallOption) (*runtimeapi.StatusResponse, error)
124124
// RuntimeConfig returns configuration information of the runtime.
125125
// A couple of notes:
126126
// - The RuntimeConfigRequest object is not to be confused with the contents of UpdateRuntimeConfigRequest.

integration/issue7496_linux_test.go

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import (
3030
"time"
3131

3232
apitask "github.com/containerd/containerd/v2/api/runtime/task/v3"
33+
shimcore "github.com/containerd/containerd/v2/core/runtime/v2"
3334
"github.com/containerd/containerd/v2/core/runtime/v2/shim"
3435
"github.com/containerd/containerd/v2/integration/images"
3536
"github.com/containerd/containerd/v2/pkg/namespaces"
@@ -49,7 +50,7 @@ func TestIssue7496(t *testing.T) {
4950
sbID, err := runtimeService.RunPodSandbox(sbConfig, *runtimeHandler)
5051
require.NoError(t, err)
5152

52-
shimCli := connectToShim(ctx, t, sbID)
53+
shimCli := connectToShim(ctx, t, containerdEndpoint, 3, sbID)
5354

5455
delayInSec := 12
5556
t.Logf("[shim pid: %d]: Injecting %d seconds delay to umount2 syscall",
@@ -155,19 +156,21 @@ func injectDelayToUmount2(ctx context.Context, t *testing.T, shimCli apitask.TTR
155156
return doneCh
156157
}
157158

158-
func connectToShim(ctx context.Context, t *testing.T, id string) apitask.TTRPCTaskService {
159-
addr, err := shim.SocketAddress(ctx, containerdEndpoint, id)
159+
func connectToShim(ctx context.Context, t *testing.T, ctrdEndpoint string, version int, id string) shimcore.TaskServiceClient {
160+
addr, err := shim.SocketAddress(ctx, ctrdEndpoint, id)
160161
require.NoError(t, err)
161162
addr = strings.TrimPrefix(addr, "unix://")
162163

163164
conn, err := net.Dial("unix", addr)
164165
require.NoError(t, err)
165166

166167
client := ttrpc.NewClient(conn)
167-
return apitask.NewTTRPCTaskClient(client)
168+
cli, err := shimcore.NewTaskClient(client, version)
169+
require.NoError(t, err)
170+
return cli
168171
}
169172

170-
func shimPid(ctx context.Context, t *testing.T, shimCli apitask.TTRPCTaskService) uint32 {
173+
func shimPid(ctx context.Context, t *testing.T, shimCli shimcore.TaskServiceClient) uint32 {
171174
resp, err := shimCli.Connect(ctx, &apitask.ConnectRequest{})
172175
require.NoError(t, err)
173176
return resp.GetShimPid()

integration/issue7496_shutdown_linux_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ func TestIssue7496_ShouldRetryShutdown(t *testing.T) {
5151
require.NoError(t, err)
5252

5353
t.Logf("Connect to the shim %s", sbID)
54-
shimCli := connectToShim(ctx, t, sbID)
54+
shimCli := connectToShim(ctx, t, containerdEndpoint, 3, sbID)
5555

5656
t.Logf("Log shim %s's pid: %d", sbID, shimPid(ctx, t, shimCli))
5757

0 commit comments

Comments
 (0)