Skip to content

Commit 9128ee0

Browse files
committed
Move nri packages to plugin and internal
NRI is still newer and mostly used by CRI plugin. Keep the package in internal to allow for interfaces as the project matures. Signed-off-by: Derek McGowan <[email protected]>
1 parent 9a2b855 commit 9128ee0

File tree

16 files changed

+9
-7
lines changed

16 files changed

+9
-7
lines changed

cmd/containerd/builtins/builtins.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ package builtins
1919
// register containerd builtins here
2020
import (
2121
_ "github.com/containerd/containerd/v2/core/runtime/v2"
22-
_ "github.com/containerd/containerd/v2/pkg/nri/plugin"
2322
_ "github.com/containerd/containerd/v2/plugins/events"
2423
_ "github.com/containerd/containerd/v2/plugins/gc"
2524
_ "github.com/containerd/containerd/v2/plugins/imageverifier"
2625
_ "github.com/containerd/containerd/v2/plugins/leases"
2726
_ "github.com/containerd/containerd/v2/plugins/metadata"
27+
_ "github.com/containerd/containerd/v2/plugins/nri"
2828
_ "github.com/containerd/containerd/v2/plugins/restart"
2929
_ "github.com/containerd/containerd/v2/plugins/sandbox"
3030
_ "github.com/containerd/containerd/v2/plugins/services/containers"

contrib/fuzz/builtins.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ package fuzz
1919
import (
2020
// base containerd imports
2121
_ "github.com/containerd/containerd/v2/core/runtime/v2"
22-
_ "github.com/containerd/containerd/v2/pkg/nri/plugin"
2322
_ "github.com/containerd/containerd/v2/plugins/cri"
2423
_ "github.com/containerd/containerd/v2/plugins/cri/images"
2524
_ "github.com/containerd/containerd/v2/plugins/cri/runtime"
@@ -29,6 +28,7 @@ import (
2928
_ "github.com/containerd/containerd/v2/plugins/imageverifier"
3029
_ "github.com/containerd/containerd/v2/plugins/leases"
3130
_ "github.com/containerd/containerd/v2/plugins/metadata"
31+
_ "github.com/containerd/containerd/v2/plugins/nri"
3232
_ "github.com/containerd/containerd/v2/plugins/restart"
3333
_ "github.com/containerd/containerd/v2/plugins/sandbox"
3434
_ "github.com/containerd/containerd/v2/plugins/services/containers"

contrib/v2-migrate.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ for GOFILE in $(find . -name "*.go" | grep -v "./vendor/" ); do
5252
perl -pi -e 's/([\t]|[ ]{2,8}|import )([_a-zA-Z0-9]+ )?"github\.com\/containerd\/containerd\/v2\/pkg\/failpoint/$1$2"github.com\/containerd\/containerd\/v2\/internal\/failpoint/g' $GOFILE
5353
perl -pi -e 's/([\t]|[ ]{2,8}|import )([_a-zA-Z0-9]+ )?"github\.com\/containerd\/containerd\/v2\/pkg\/hasher/$1$2"github.com\/containerd\/containerd\/v2\/internal\/hasher/g' $GOFILE
5454
perl -pi -e 's/([\t]|[ ]{2,8}|import )([_a-zA-Z0-9]+ )?"github\.com\/containerd\/containerd\/v2\/pkg\/kmutex/$1$2"github.com\/containerd\/containerd\/v2\/internal\/kmutex/g' $GOFILE
55+
perl -pi -e 's/([\t]|[ ]{2,8}|import )([_a-zA-Z0-9]+ )?"github\.com\/containerd\/containerd\/v2\/pkg\/nri\/plugin/$1$2"github.com\/containerd\/containerd\/v2\/plugins\/nri/g' $GOFILE
56+
perl -pi -e 's/([\t]|[ ]{2,8}|import )([_a-zA-Z0-9]+ )?"github\.com\/containerd\/containerd\/v2\/pkg\/nri/$1$2"github.com\/containerd\/containerd\/v2\/internal\/nri/g' $GOFILE
5557
perl -pi -e 's/([\t]|[ ]{2,8}|import )([_a-zA-Z0-9]+ )?"github\.com\/containerd\/containerd\/v2\/pkg\/randutil/$1$2"github.com\/containerd\/containerd\/v2\/internal\/randutil/g' $GOFILE
5658
perl -pi -e 's/([\t]|[ ]{2,8}|import )([_a-zA-Z0-9]+ )?"github\.com\/containerd\/containerd\/v2\/pkg\/registrar/$1$2"github.com\/containerd\/containerd\/v2\/internal\/registrar/g' $GOFILE
5759
perl -pi -e 's/([\t]|[ ]{2,8}|import )([_a-zA-Z0-9]+ )?"github\.com\/containerd\/containerd\/v2\/pkg\/streaming/$1$2"github.com\/containerd\/containerd\/v2\/core\/streaming/g' $GOFILE

internal/cri/nri/nri_api_linux.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ import (
3636
"github.com/opencontainers/runtime-tools/generate"
3737
cri "k8s.io/cri-api/pkg/apis/runtime/v1"
3838

39-
"github.com/containerd/containerd/v2/pkg/nri"
39+
"github.com/containerd/containerd/v2/internal/nri"
4040
"github.com/containerd/nri/pkg/api"
4141
nrigen "github.com/containerd/nri/pkg/runtime-tools/generate"
4242
)

internal/cri/nri/nri_api_other.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import (
2929
cri "k8s.io/cri-api/pkg/apis/runtime/v1"
3030

3131
"github.com/containerd/containerd/v2/internal/cri/constants"
32-
"github.com/containerd/containerd/v2/pkg/nri"
32+
"github.com/containerd/containerd/v2/internal/nri"
3333

3434
"github.com/containerd/nri/pkg/api"
3535
)
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)