fix: return gRPC code "unavailable" if server is not initialized yet

koct9i · koct9i · commit c191935747bf · 2023-12-20T11:07:18.000+01:00
Correct error code helps client to decide when it should retry request.

Signed-off-by: Konstantin Khlebnikov &lt;koct9i@gmail.com&gt;
diff --git a/pkg/cri/instrument/instrumented_service.go b/pkg/cri/instrument/instrumented_service.go
@@ -18,7 +18,6 @@ package instrument
 
 import (
 	"context"
-	"errors"
 
 	"github.com/containerd/containerd/v2/errdefs"
 	"github.com/containerd/containerd/v2/tracing"
@@ -63,7 +62,7 @@ func (in *instrumentedService) checkInitialized() error {
 	if in.c.IsInitialized() {
 		return nil
 	}
-	return errors.New("server is not initialized yet")
+	return errdefs.ToGRPCf(errdefs.ErrUnavailable, "server is not initialized yet")
 }
 
 func (in *instrumentedService) RunPodSandbox(ctx context.Context, r *runtime.RunPodSandboxRequest) (res *runtime.RunPodSandboxResponse, err error) {

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@ package instrument`
`18`	`18`
`19`	`19`	`import (`
`20`	`20`	`"context"`
`21`		`- "errors"`
`22`	`21`
`23`	`22`	`"github.com/containerd/containerd/v2/errdefs"`
`24`	`23`	`"github.com/containerd/containerd/v2/tracing"`
`@@ -63,7 +62,7 @@ func (in *instrumentedService) checkInitialized() error {`
`63`	`62`	`if in.c.IsInitialized() {`
`64`	`63`	`return nil`
`65`	`64`	`}`
`66`		`- return errors.New("server is not initialized yet")`
	`65`	`+ return errdefs.ToGRPCf(errdefs.ErrUnavailable, "server is not initialized yet")`
`67`	`66`	`}`
`68`	`67`
`69`	`68`	`func (in instrumentedService) RunPodSandbox(ctx context.Context, r runtime.RunPodSandboxRequest) (res *runtime.RunPodSandboxResponse, err error) {`