chore: add GroupAdd option

Signed-off-by: Arjun Raja Yogidas <[email protected]>

Author: coderbirju

api/handlers/container/create.go

@@ -149,6 +149,11 @@ func (h *handler) create(w http.ResponseWriter, r *http.Request) {
 		volumesFrom = req.HostConfig.VolumesFrom
 	}
 
+	groupAdd := []string{}
+	if req.HostConfig.GroupAdd != nil {
+		groupAdd = req.HostConfig.GroupAdd
+	}
+
 	globalOpt := ncTypes.GlobalCommandOptions(*h.Config)
 	createOpt := ncTypes.ContainerCreateOptions{
 		Stdout:   nil,
@@ -193,7 +198,7 @@ func (h *handler) create(w http.ResponseWriter, r *http.Request) {
 
 		// #region for user flags
 		User:     req.User,
-		GroupAdd: []string{}, // nerdctl default.
+		GroupAdd: groupAdd,
 		// #endregion
 
 		// #region for security flags

api/handlers/container/create_test.go

@@ -583,17 +583,19 @@ var _ = Describe("Container Create API ", func() {
 			Expect(rr.Body).Should(MatchJSON(jsonResponse))
 		})
 
-		It("should set CapDrop option", func() {
+		It("should set CapDrop and GroupAdd option", func() {
 			body := []byte(`{
 				"Image": "test-image",
 				"HostConfig": {
-					"CapDrop": ["MKNOD"]
+					"CapDrop": ["MKNOD"],
+					"GroupAdd": ["someGroup"]
 				}
 			}`)
 			req, _ := http.NewRequest(http.MethodPost, "/containers/create", bytes.NewReader(body))
 
 			// expected create options
 			createOpt.CapDrop = []string{"MKNOD"}
+			createOpt.GroupAdd = []string{"someGroup"}
 
 			service.EXPECT().Create(gomock.Any(), "test-image", nil, equalTo(createOpt), equalTo(netOpt)).Return(
 				cid, nil)

api/types/container_types.go

@@ -77,7 +77,7 @@ type ContainerHostConfig struct {
 	DNSOptions []string `json:"DnsOptions"` // List of DNSOption to look for
 	DNSSearch  []string `json:"DnsSearch"`  // List of DNSSearch to look for
 	ExtraHosts []string // List of extra hosts
-	// TODO: GroupAdd        []string          // List of additional groups that the container process will run as
+	GroupAdd   []string // List of additional groups that the container process will run as
 	// TODO: IpcMode         IpcMode           // IPC namespace to use for the container
 	// TODO: Cgroup          CgroupSpec        // Cgroup to use for the container
 	// TODO: Links           []string          // List of links (in the name:alias form)