test: improve date parsing robustness (runfinch#206)

* test: improve date parsing robustness

Signed-off-by: Justin Alvarez <[email protected]>

* add debug logging

Signed-off-by: Justin Alvarez <[email protected]>

* more debug

Signed-off-by: Justin Alvarez <[email protected]>

* bump test versions

Signed-off-by: Justin Alvarez <[email protected]>

* undo debug changes

Signed-off-by: Justin Alvarez <[email protected]>

* unfocus test

Signed-off-by: Justin Alvarez <[email protected]>

---------

Signed-off-by: Justin Alvarez <[email protected]>

Author: pendo324

e2e/tests/container_restart.go

@@ -8,7 +8,9 @@ import (
 	"fmt"
 	"io"
 	"net/http"
+	"strings"
 	"time"
+	"unicode"
 
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
@@ -40,7 +42,10 @@ func ContainerRestart(opt *option.Option) {
 		It("should start and restart the container", func() {
 			containerShouldBeRunning(opt, testContainerName)
 
-			before := time.Now().Round(0)
+			// use location to ensure all times are UTC since
+			// the default location is different on different platforms
+			lo, _ := time.LoadLocation("UTC")
+			before := time.Now().In(lo).Round(0)
 
 			restartRelativeUrl := fmt.Sprintf("/containers/%s/restart", testContainerName)
 			res, err := uClient.Post(client.ConvertToFinchUrl(version, restartRelativeUrl), "application/json", nil)
@@ -57,8 +62,13 @@ func ContainerRestart(opt *option.Option) {
 			body, err := io.ReadAll(res.Body)
 			Expect(err).Should(BeNil())
 
-			dateStr := string(body[8 : len(body)-1])
-			date, _ := time.Parse(time.UnixDate, dateStr)
+			// get the second date from the container logs, which are newline delimited
+			// and strip newlines, spaces, and non-printable characters
+			dateStr := strings.TrimFunc(strings.Split(string(body), "\n")[1], func(r rune) bool {
+				return !unicode.IsGraphic(r) || unicode.IsSpace(r)
+			})
+			date, err := time.ParseInLocation(time.UnixDate, dateStr, lo)
+			Expect(err).Should(BeNil())
 			Expect(before.Before(date)).Should(BeTrue())
 		})
 		It("should fail to restart container that does not exist", func() {

setup-test-env.sh

@@ -1,8 +1,8 @@
 #!/bin/bash
 # Set versions
-RUNC_VERSION=1.1.14
-NERDCTL_VERSION=2.0.0
-BUILDKIT_VERSION=0.15.2
+RUNC_VERSION=1.2.4
+NERDCTL_VERSION=2.0.3
+BUILDKIT_VERSION=0.18.1
 CNI_VERSION=1.6.2
 
 apt update && apt install -y make gcc linux-libc-dev libseccomp-dev pkg-config git