Skip to content

Commit 402afcd

Browse files
authored
ci: update headers and footers for release-please (runfinch#1581)
Adds a footer to the release-please PR to ensure release-approvers have a checklist to verify that the release pre-reqs have completed correctly Signed-off-by: Arjun Raja Yogidas <[email protected]>
1 parent 63fe81d commit 402afcd

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

.github/workflows/ci-docs.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ on:
2121
- 'scripts/**'
2222
- 'msi-builder/**'
2323
- '.github/**'
24+
- 'release-please-config.json'
25+
- '.release-please-manifest.json'
2426
- '!.github/workflows/e2e-macos.yaml'
2527
- '!.github/workflows/e2e-windows.yaml'
2628
- '!.github/workflows/e2e-linux.yaml'
@@ -36,6 +38,8 @@ on:
3638
- 'scripts/**'
3739
- 'msi-builder/**'
3840
- '.github/**'
41+
- 'release-please-config.json'
42+
- '.release-please-manifest.json'
3943
- '!.github/workflows/e2e-macos.yaml'
4044
- '!.github/workflows/e2e-windows.yaml'
4145
- '!.github/workflows/e2e-linux.yaml'

release-please-config.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,5 +55,7 @@
5555
],
5656
"packages": {
5757
".": {}
58-
}
58+
},
59+
"pull-request-header": "Ready for new finch release - Please verify the checklist items in the bottom of this PR before merging",
60+
"pull-request-footer": "---\n\n### 🤖 IMPORTANT Please Read\n\nThis PR was generated automatically by [release-please](https://github.com/googleapis/release-please).\n\n**Please verify the following before merging this PR:**\n1. The Sync Submodules workflow has completed successfully in [finch-core](https://github.com/runfinch/finch-core/actions/workflows/submodulesync.yaml) repo\n2. The [Sync Submodules and Dependencies](https://github.com/runfinch/finch/actions/workflows/sync-submodules-and-deps.yaml) Workflow has completed successfully in this repo and the subsequent PR has been merged\n3. Latest run of [samcli-vm](https://github.com/runfinch/finch-daemon/actions/workflows/samcli-vm.yaml) tests are sucessful\n\n**Need to make changes?** Push additional commits to main and this PR will be updated automatically."
5961
}

0 commit comments

Comments
 (0)