Skip to content

Commit 0ac0168

Browse files
authored
Merge pull request containerd#3557 from apostasie/tweak-docker-failing-test
Add delay to tentatively fix flakyness with Docker
2 parents a201ea1 + 645988e commit 0ac0168

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

cmd/nerdctl/container/container_logs_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,9 @@ func TestLogsWithInheritedFlags(t *testing.T) {
9595
base.Cmd("run", "-d", "--name", containerName, testutil.CommonImage,
9696
"sh", "-euxc", "echo foo; echo bar").AssertOK()
9797

98+
// It appears this test flakes out with Docker seeing only "foo\n"
99+
// Tentatively adding a pause in case this is just slow
100+
time.Sleep(time.Second)
98101
// test rootCmd alias `-n` already used in logs subcommand
99102
base.Cmd("logs", "-n", "1", containerName).AssertOutWithFunc(func(stdout string) error {
100103
if !(stdout == "bar\n" || stdout == "") {

0 commit comments

Comments
 (0)