Enable rootful unit testing on linux

Signed-off-by: apostasie <[email protected]>

Author: apostasie

.github/workflows/job-test-unit.yml

@@ -80,3 +80,9 @@ jobs:
         name: "Run"
         run: |
           make test-unit
+
+      # On linux, also run with root
+      - if: ${{ env.GO_VERSION != '' && env.RUNNER_OS == 'Linux' }}
+        name: "Run: with root"
+        run: |
+          sudo make test-unit

pkg/imgutil/dockerconfigresolver/credentialsstore_test.go

@@ -25,6 +25,8 @@ import (
 	"testing"
 
 	"gotest.tools/v3/assert"
+
+	"github.com/containerd/nerdctl/v2/pkg/rootlessutil"
 )
 
 func createTempDir(t *testing.T, mode os.FileMode) string {
@@ -40,12 +42,10 @@ func createTempDir(t *testing.T, mode os.FileMode) string {
 }
 
 func TestBrokenCredentialsStore(t *testing.T) {
-	if runtime.GOOS == "freebsd" {
-		// It is unclear why these tests are failing on FreeBSD, and if it is a problem with Vagrant or differences
-		// with FreeBSD
-		// Anyhow, this test is about extreme cases & conditions (filesystem errors wrt credentials loading).
-		t.Skip("skipping broken credential store tests for freebsd")
+	if !rootlessutil.IsRootless() {
+		t.Skip("test is for rootless")
 	}
+
 	if runtime.GOOS == "windows" {
 		// Same as above
 		t.Skip("test is not compatible with windows")

pkg/netutil/netutil_test.go

@@ -34,7 +34,7 @@ import (
 	"github.com/containerd/nerdctl/v2/pkg/testutil"
 )
 
-const testBridgeIP = "10.1.100.1/24" // nolint:unused
+const testBridgeIP = "10.42.100.1/24" // nolint:unused
 
 const preExistingNetworkConfigTemplate = `
 {
@@ -278,8 +278,8 @@ func testDefaultNetworkCreationWithBridgeIP(t *testing.T) {
 	// Assert on bridge plugin configuration
 	assert.Equal(t, "bridge", bridgeConfig.Type)
 	// Assert on IPAM configuration
-	assert.Equal(t, "10.1.100.1", bridgeConfig.IPAM.Ranges[0][0].Gateway)
-	assert.Equal(t, "10.1.100.0/24", bridgeConfig.IPAM.Ranges[0][0].Subnet)
+	assert.Equal(t, "10.42.100.1", bridgeConfig.IPAM.Ranges[0][0].Gateway)
+	assert.Equal(t, "10.42.100.0/24", bridgeConfig.IPAM.Ranges[0][0].Subnet)
 	assert.Equal(t, "0.0.0.0/0", bridgeConfig.IPAM.Routes[0].Dst)
 	assert.Equal(t, "host-local", bridgeConfig.IPAM.Type)