Skip to content

Commit 324c490

Browse files
authored
Merge pull request containerd#3611 from apostasie/series-9
Rewrite container prune test
2 parents fa15069 + b722721 commit 324c490

File tree

1 file changed

+23
-23
lines changed

1 file changed

+23
-23
lines changed

cmd/nerdctl/container/container_prune_linux_test.go

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -20,36 +20,36 @@ import (
2020
"testing"
2121

2222
"github.com/containerd/nerdctl/v2/pkg/testutil"
23+
"github.com/containerd/nerdctl/v2/pkg/testutil/nerdtest"
24+
"github.com/containerd/nerdctl/v2/pkg/testutil/test"
2325
)
2426

2527
func TestPruneContainer(t *testing.T) {
26-
base := testutil.NewBase(t)
27-
tID := testutil.Identifier(t)
28+
testCase := nerdtest.Setup()
2829

29-
tearDown := func() {
30-
defer base.Cmd("rm", "-f", tID+"-1").Run()
31-
defer base.Cmd("rm", "-f", tID+"-2").Run()
32-
}
30+
testCase.Require = nerdtest.Private
3331

34-
tearUp := func() {
35-
base.Cmd("run", "-d", "--name", tID+"-1", "-v", "/anonymous", testutil.CommonImage, "sleep", "infinity").AssertOK()
36-
base.Cmd("exec", tID+"-1", "touch", "/anonymous/foo").AssertOK()
37-
base.Cmd("create", "--name", tID+"-2", testutil.CommonImage, "sleep", "infinity").AssertOK()
32+
testCase.Cleanup = func(data test.Data, helpers test.Helpers) {
33+
helpers.Anyhow("rm", "-f", data.Identifier("1"))
34+
helpers.Anyhow("rm", "-f", data.Identifier("2"))
3835
}
3936

40-
tearDown()
41-
t.Cleanup(tearDown)
42-
tearUp()
43-
44-
base.Cmd("container", "prune", "-f").AssertOK()
45-
// tID-1 is still running, tID-2 is not
46-
base.Cmd("inspect", tID+"-1").AssertOK()
47-
base.Cmd("inspect", tID+"-2").AssertFail()
37+
testCase.Setup = func(data test.Data, helpers test.Helpers) {
38+
helpers.Ensure("run", "-d", "--name", data.Identifier("1"), "-v", "/anonymous", testutil.CommonImage, "sleep", "infinity")
39+
helpers.Ensure("exec", data.Identifier("1"), "touch", "/anonymous/foo")
40+
helpers.Ensure("create", "--name", data.Identifier("2"), testutil.CommonImage, "sleep", "infinity")
41+
}
4842

49-
// https://github.com/containerd/nerdctl/issues/3134
50-
base.Cmd("exec", tID+"-1", "ls", "-lA", "/anonymous/foo").AssertOK()
43+
testCase.Command = func(data test.Data, helpers test.Helpers) test.TestableCommand {
44+
helpers.Ensure("container", "prune", "-f")
45+
helpers.Ensure("inspect", data.Identifier("1"))
46+
helpers.Fail("inspect", data.Identifier("2"))
47+
// https://github.com/containerd/nerdctl/issues/3134
48+
helpers.Ensure("exec", data.Identifier("1"), "ls", "-lA", "/anonymous/foo")
49+
helpers.Ensure("kill", data.Identifier("1"))
50+
helpers.Ensure("container", "prune", "-f")
51+
return helpers.Command("inspect", data.Identifier("1"))
52+
}
5153

52-
base.Cmd("kill", tID+"-1").AssertOK()
53-
base.Cmd("container", "prune", "-f").AssertOK()
54-
base.Cmd("inspect", tID+"-1").AssertFail()
54+
testCase.Expected = test.Expects(1, nil, nil)
5555
}

0 commit comments

Comments
 (0)