Skip to content

Commit 83c6404

Browse files
authored
Merge pull request containerd#3608 from apostasie/series-6
Rewrite container_wait tests
2 parents e33707b + 4d06e73 commit 83c6404

File tree

1 file changed

+19
-16
lines changed

1 file changed

+19
-16
lines changed

cmd/nerdctl/container/container_wait_test.go

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -20,28 +20,31 @@ import (
2020
"testing"
2121

2222
"github.com/containerd/nerdctl/v2/pkg/testutil"
23+
"github.com/containerd/nerdctl/v2/pkg/testutil/nerdtest"
24+
"github.com/containerd/nerdctl/v2/pkg/testutil/test"
2325
)
2426

2527
func TestWait(t *testing.T) {
26-
t.Parallel()
27-
tID := testutil.Identifier(t)
28-
testContainerName1 := tID + "-1"
29-
testContainerName2 := tID + "-2"
30-
testContainerName3 := tID + "-3"
28+
testCase := nerdtest.Setup()
3129

32-
const expected = `0
33-
0
34-
123
35-
`
36-
base := testutil.NewBase(t)
37-
defer base.Cmd("rm", "-f", testContainerName1, testContainerName2, testContainerName3).Run()
38-
39-
base.Cmd("run", "-d", "--name", testContainerName1, testutil.CommonImage, "sleep", "1").AssertOK()
30+
testCase.Cleanup = func(data test.Data, helpers test.Helpers) {
31+
helpers.Anyhow("rm", "-f", data.Identifier("1"), data.Identifier("2"), data.Identifier("3"))
32+
}
4033

41-
base.Cmd("run", "-d", "--name", testContainerName2, testutil.CommonImage, "sleep", "1").AssertOK()
34+
testCase.Setup = func(data test.Data, helpers test.Helpers) {
35+
helpers.Ensure("run", "-d", "--name", data.Identifier("1"), testutil.CommonImage)
36+
helpers.Ensure("run", "-d", "--name", data.Identifier("2"), testutil.CommonImage, "sleep", "1")
37+
helpers.Ensure("run", "-d", "--name", data.Identifier("3"), testutil.CommonImage, "sh", "-euxc", "sleep 5; exit 123")
38+
}
4239

43-
base.Cmd("run", "--name", testContainerName3, testutil.CommonImage, "sh", "-euxc", "sleep 5; exit 123").AssertExitCode(123)
40+
testCase.Command = func(data test.Data, helpers test.Helpers) test.TestableCommand {
41+
return helpers.Command("wait", data.Identifier("1"), data.Identifier("2"), data.Identifier("3"))
42+
}
4443

45-
base.Cmd("wait", testContainerName1, testContainerName2, testContainerName3).AssertOutExactly(expected)
44+
testCase.Expected = test.Expects(0, nil, test.Equals(`0
45+
0
46+
123
47+
`))
4648

49+
testCase.Run(t)
4750
}

0 commit comments

Comments
 (0)