Merge pull request containerd#3912 from apostasie/fix-3907

[PRIORITY] fix: prevent acquire from blanking out hosts file

Author: AkihiroSuda

pkg/dnsutil/hostsstore/hostsstore.go

@@ -112,16 +112,21 @@ func (x *hostsStore) Acquire(meta Meta) (err error) {
 			return err
 		}
 
-		if err = os.WriteFile(loc, []byte{}, 0o644); err != nil {
-			return errors.Join(store.ErrSystemFailure, err)
-		}
+		// See https://github.com/containerd/nerdctl/issues/3907
+		// Because of the way we call network manager ContainerNetworkingOpts then SetupNetworking in sequence
+		// we need to make sure we do not overwrite an already allocated hosts file.
+		if _, err = os.Stat(loc); os.IsNotExist(err) {
+			if err = os.WriteFile(loc, []byte{}, 0o644); err != nil {
+				return errors.Join(store.ErrSystemFailure, err)
+			}
 
-		// os.WriteFile relies on syscall.Open. Unless there are ACLs, the effective mode of the file will be matched
-		// against the current process umask.
-		// See https://www.man7.org/linux/man-pages/man2/open.2.html for details.
-		// Since we must make sure that these files are world readable, explicitly chmod them here.
-		if err = os.Chmod(loc, 0o644); err != nil {
-			err = errors.Join(store.ErrSystemFailure, err)
+			// os.WriteFile relies on syscall.Open. Unless there are ACLs, the effective mode of the file will be matched
+			// against the current process umask.
+			// See https://www.man7.org/linux/man-pages/man2/open.2.html for details.
+			// Since we must make sure that these files are world readable, explicitly chmod them here.
+			if err = os.Chmod(loc, 0o644); err != nil {
+				err = errors.Join(store.ErrSystemFailure, err)
+			}
 		}
 
 		var content []byte