Fix freebsd lint

Signed-off-by: apostasie <[email protected]>

Author: apostasie

cmd/nerdctl/container/container_cp_linux.go

@@ -17,7 +17,10 @@
 package container
 
 import (
+	"errors"
 	"fmt"
+	"path/filepath"
+	"strings"
 
 	"github.com/spf13/cobra"
 
@@ -131,3 +134,46 @@ func processCpOptions(cmd *cobra.Command, args []string) (types.ContainerCpOptio
 func AddCpCommand(rootCmd *cobra.Command) {
 	rootCmd.AddCommand(newCpCommand())
 }
+
+var errFileSpecDoesntMatchFormat = errors.New("filespec must match the canonical format: [container:]file/path")
+
+func parseCpFileSpec(arg string) (*cpFileSpec, error) {
+	i := strings.Index(arg, ":")
+
+	// filespec starting with a semicolon is invalid
+	if i == 0 {
+		return nil, errFileSpecDoesntMatchFormat
+	}
+
+	if filepath.IsAbs(arg) {
+		// Explicit local absolute path, e.g., `C:\foo` or `/foo`.
+		return &cpFileSpec{
+			Container: nil,
+			Path:      arg,
+		}, nil
+	}
+
+	parts := strings.SplitN(arg, ":", 2)
+
+	if len(parts) == 1 || strings.HasPrefix(parts[0], ".") {
+		// Either there's no `:` in the arg
+		// OR it's an explicit local relative path like `./file:name.txt`.
+		return &cpFileSpec{
+			Path: arg,
+		}, nil
+	}
+
+	return &cpFileSpec{
+		Container: &parts[0],
+		Path:      parts[1],
+	}, nil
+}
+
+type cpFileSpec struct {
+	Container *string
+	Path      string
+}
+
+func cpShellComplete(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+	return nil, cobra.ShellCompDirectiveFilterFileExt
+}

cmd/nerdctl/container/container_cp_unix.go

@@ -649,6 +649,7 @@ func writeEtcHostnameForContainer(globalOptions types.GlobalCommandOptions, host
 
 // Loads all available networks and verifies that every selected network
 // from the networkSlice is of a type within supportedTypes.
+// nolint:unused
 func verifyNetworkTypes(env *netutil.CNIEnv, networkSlice []string, supportedTypes []string) (map[string]*netutil.NetworkConfig, error) {
 	netMap, err := env.NetworkMap()
 	if err != nil {

pkg/containerutil/container_network_manager.go

@@ -133,6 +133,7 @@ func TestParseIPAMRange(t *testing.T) {
 // Note that this test will require a CNI driver bearing the same name as
 // the type of the default network. (denoted by netutil.DefaultNetworkName,
 // which is used as both the name of the default network and its Driver)
+// nolint:unused
 func testDefaultNetworkCreation(t *testing.T) {
 	// To prevent subnet collisions when attempting to recreate the default network
 	// in the isolated CNI config dir we'll be using, we must first delete

pkg/netutil/netutil_test.go

@@ -18,5 +18,4 @@ package ocihook
 
 func loadAppArmor() {
 	//noop
-	return
 }

pkg/ocihook/ocihook_freebsd.go

@@ -16,6 +16,8 @@
 
 package testutil
 
+import "fmt"
+
 const (
 	CommonImage = "docker.io/knast/freebsd:13-STABLE"
 
@@ -26,3 +28,13 @@ const (
 	// https://www.rfc-editor.org/rfc/rfc793
 	ExpectedConnectionRefusedError = "connection refused"
 )
+
+var (
+	AlpineImage      = mirrorOf("alpine:3.13")
+	NginxAlpineImage = mirrorOf("nginx:1.19-alpine")
+)
+
+func mirrorOf(s string) string {
+	// plain mirror, NOT stargz-converted images
+	return fmt.Sprintf("ghcr.io/stargz-containers/%s-org", s)
+}