test: refactor TestRunWithInvalidPortThenCleanUp

This commit refactors TestRunWithInvalidPortThenCleanUp in
cmd/nerdctl/container/container_run_network_linux_test.go based on the
principles in the following document.

- https://github.com/containerd/nerdctl/tree/main/docs/testing#principles

Signed-off-by: Hayato Kiwata <[email protected]>

Author: haytok

cmd/nerdctl/container/container_run_network_linux_test.go

@@ -41,6 +41,7 @@ import (
 	"github.com/containerd/nerdctl/v2/pkg/testutil"
 	"github.com/containerd/nerdctl/v2/pkg/testutil/nerdtest"
 	"github.com/containerd/nerdctl/v2/pkg/testutil/nettestutil"
+	"github.com/containerd/nerdctl/v2/pkg/testutil/test"
 )
 
 func extractHostPort(portMapping string, port string) (string, error) {
@@ -350,15 +351,29 @@ func TestRunPort(t *testing.T) {
 }
 
 func TestRunWithInvalidPortThenCleanUp(t *testing.T) {
+	testCase := nerdtest.Setup()
 	// docker does not set label restriction to 4096 bytes
-	testutil.DockerIncompatible(t)
-	t.Parallel()
-	base := testutil.NewBase(t)
-	containerName := testutil.Identifier(t)
-	defer base.Cmd("rm", "-f", containerName).Run()
-	base.Cmd("run", "--rm", "--name", containerName, "-p", "22200-22299:22200-22299", testutil.CommonImage).AssertFail()
-	base.Cmd("run", "--rm", "--name", containerName, "-p", "22200-22299:22200-22299", testutil.CommonImage).AssertCombinedOutContains(errdefs.ErrInvalidArgument.Error())
-	base.Cmd("run", "--rm", "--name", containerName, testutil.CommonImage).AssertOK()
+	testCase.Require = test.Not(nerdtest.Docker)
+
+	testCase.SubTests = []*test.Case{
+		{
+			Description: "Run a container with invalid ports, and then clean up.",
+			Cleanup: func(data test.Data, helpers test.Helpers) {
+				helpers.Anyhow("rm", "--data-root", data.TempDir(), "-f", data.Identifier())
+			},
+			Command: func(data test.Data, helpers test.Helpers) test.TestableCommand {
+				return helpers.Command("run", "--data-root", data.TempDir(), "--rm", "--name", data.Identifier(), "-p", "22200-22299:22200-22299", testutil.CommonImage)
+			},
+			Expected: func(data test.Data, helpers test.Helpers) *test.Expected {
+				return &test.Expected{
+					ExitCode: 1,
+					Errors:   []error{errdefs.ErrInvalidArgument},
+				}
+			},
+		},
+	}
+
+	testCase.Run(t)
 }
 
 func TestRunContainerWithStaticIP(t *testing.T) {