Skip to content

Commit ed86d37

Browse files
authored
Merge pull request containerd#3617 from apostasie/update-busybox
Update busybox image (support sleep inf)
2 parents 49a19ed + 40ddd34 commit ed86d37

File tree

4 files changed

+9
-10
lines changed

4 files changed

+9
-10
lines changed

cmd/nerdctl/builder/builder_builder_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ CMD ["echo", "nerdctl-builder-debug-test-string"]`, testutil.CommonImage)
9090
// FIXME: this test should be rewritten to dynamically retrieve the ids, and use images
9191
// available on all platforms
9292
oldImage := testutil.BusyboxImage
93-
oldImageSha := "141c253bc4c3fd0a201d32dc1f493bcf3fff003b6df416dea4f41046e0f37d47"
93+
oldImageSha := "7b3ccabffc97de872a30dfd234fd972a66d247c8cfc69b0550f276481852627c"
9494
newImage := testutil.AlpineImage
9595
newImageSha := "ec14c7992a97fc11425907e908340c6c3d6ff602f5f13d899e6b7027c9b4133a"
9696

pkg/testutil/testutil_freebsd.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ const (
3030
)
3131

3232
var (
33-
BusyboxImage = mirrorOf("busybox:1.28")
33+
BusyboxImage = "ghcr.io/containerd/busybox:1.36"
3434
AlpineImage = mirrorOf("alpine:3.13")
3535
NginxAlpineImage = mirrorOf("nginx:1.19-alpine")
3636
GolangImage = mirrorOf("golang:1.18")

pkg/testutil/testutil_linux.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ func mirrorOf(s string) string {
3030
}
3131

3232
var (
33-
BusyboxImage = "ghcr.io/containerd/busybox:1.28"
33+
BusyboxImage = "ghcr.io/containerd/busybox:1.36"
3434
AlpineImage = mirrorOf("alpine:3.13")
3535
NginxAlpineImage = mirrorOf("nginx:1.19-alpine")
3636
NginxAlpineIndexHTMLSnippet = "<title>Welcome to nginx!</title>"

pkg/testutil/testutil_windows.go

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,23 +29,22 @@ import (
2929
)
3030

3131
const (
32-
WindowsNano = "gcr.io/k8s-staging-e2e-test-images/busybox:1.29-2"
33-
3432
// CommonImage.
3533
//
3634
// More work needs to be done to support windows containers in test framework
3735
// for the tests that are run now this image (used in k8s upstream testing) meets the needs
38-
// use gcr.io/k8s-staging-e2e-test-images/busybox:1.29-2-windows-amd64-ltsc2022 locally on windows 11
36+
// use gcr.io/k8s-staging-e2e-test-images/busybox:1.36-1-windows-amd64-ltsc2022 locally on windows 11
3937
// https://github.com/microsoft/Windows-Containers/issues/179
40-
CommonImage = WindowsNano
38+
BusyboxImage = "gcr.io/k8s-staging-e2e-test-images/busybox:1.36.1-1"
39+
WindowsNano = BusyboxImage
40+
CommonImage = WindowsNano
4141

4242
// NOTE(aznashwan): the upstream e2e Nginx test image is actually based on BusyBox.
4343
NginxAlpineImage = "registry.k8s.io/e2e-test-images/nginx:1.14-2"
4444
NginxAlpineIndexHTMLSnippet = "<title>Welcome to nginx!</title>"
4545

46-
GolangImage = "fixme-test-using-this-image-is-disabled-on-windows"
47-
BusyboxImage = "fixme-test-using-this-image-is-disabled-on-windows"
48-
AlpineImage = "fixme-test-using-this-image-is-disabled-on-windows"
46+
GolangImage = "fixme-test-using-this-image-is-disabled-on-windows"
47+
AlpineImage = "fixme-test-using-this-image-is-disabled-on-windows"
4948

5049
// This error string is expected when attempting to connect to a TCP socket
5150
// for a service which actively refuses the connection.

0 commit comments

Comments
 (0)