id errors 6

Signed-off-by: Arjun Raja Yogidas <[email protected]>

Author: coderbirju

cmd/nerdctl/container/container_inspect_linux_test.go

@@ -17,6 +17,7 @@
 package container
 
 import (
+	"encoding/json"
 	"fmt"
 	"strings"
 	"testing"
@@ -62,12 +63,18 @@ func TestContainerInspectContainsMounts(t *testing.T) {
 		"--name", testContainer,
 		"--network", "none",
 		"-v", "/anony-vol",
+		"--tmpfs", "/app1:size=64m",
 		"--mount", "type=bind,src=/tmp,dst=/app2,ro",
 		"--mount", fmt.Sprintf("type=volume,src=%s,dst=/app3,readonly=false", testVolume),
 		testutil.NginxAlpineImage).AssertOK()
 
 	inspect := base.InspectContainer(testContainer)
-	t.Logf("inspect in TestContainerInspectContainsMounts: %+v", inspect)
+	inspectJSON, err := json.MarshalIndent(inspect, "", "  ")
+	if err != nil {
+		t.Errorf("Failed to marshal inspect: %v", err)
+	} else {
+		t.Logf("inspect in TestContainerInspectContainsMounts:\n%s", string(inspectJSON))
+	}
 	t.Logf("inspect.Mounts in TestContainerInspectContainsMounts: %+v", inspect.Mounts)
 	// convert array to map to get by key of Destination
 	actual := make(map[string]dockercompat.MountPoint)

pkg/inspecttypes/dockercompat/dockercompat.go

@@ -347,7 +347,9 @@ func ContainerFromNative(n *native.Container) (*Container, error) {
 			tmpfsMounts = filterTmpfsMounts(mounts)
 		}
 	}
-	c.HostConfig.Tmpfs = tmpfsMounts
+	if len(tmpfsMounts) > 0 {
+		c.HostConfig.Tmpfs = tmpfsMounts
+	}
 
 	if nedctlExtraHosts := n.Labels[labels.ExtraHosts]; nedctlExtraHosts != "" {
 		c.HostConfig.ExtraHosts = parseExtraHosts(nedctlExtraHosts)