Fine-tune shell scripts

Added some modularity in our installation scripts by moving versions
into their own variable. Also added an integrity check for cmake, as
well as TODO comments for the other scripts.

Signed-off-by: David Son <[email protected]>

Author: sondavidb

scripts/install-dep.sh

@@ -22,33 +22,72 @@ set -eux -o pipefail
 TMPDIR=$(mktemp -d)
 pushd "${TMPDIR}"
 
+arch="$(uname -m)"
+
 # install cmake
+cmake_ver="3.24.1"
 if ! command -v cmake &> /dev/null
 then
-    wget https://github.com/Kitware/CMake/releases/download/v3.24.1/cmake-3.24.1-Linux-x86_64.sh -O cmake.sh
+    wget https://github.com/Kitware/CMake/releases/download/v"${cmake_ver}"/cmake-"${cmake_ver}"-Linux-"${arch}".sh -O cmake.sh
+    wget https://github.com/Kitware/CMake/releases/download/v"${cmake_ver}"/cmake-"${cmake_ver}"-SHA-256.txt -O shasums.txt
+
+    # Verify integrity
+
+    # The sha256sum will come in the format like the following:
+    # sha256hash filename
+    # Since we rename the script for convenience purposes,
+    # we only want to compare hashes to verify file integrity.
+    cmake_expected_shasum="$(grep "${arch}".sh < shasums.txt | awk '{print $1}')"
+    cmake_actual_shasum="$(sha256sum cmake.sh | awk '{print $1}')"
+    if [ "${cmake_expected_shasum}" != "${cmake_actual_shasum}" ]
+    then
+        echo "error: cmake sha256sum did not match"
+        exit 1
+    fi
+    
     sh cmake.sh --prefix=/usr/local/ --exclude-subdir
     rm -rf cmake.sh
 else
     echo "cmake is installed, skip..."
 fi
 
 # install flatc
+flatc_ver="2.0.8"
+flatc_expected_shasum="f97965a727d26386afaefff950badef2db3ab6af9afe23ed6d94bfb65f95f37e"
 if ! command -v flatc &> /dev/null
 then
-    wget https://github.com/google/flatbuffers/archive/refs/tags/v2.0.8.tar.gz -O flatbuffers.tar.gz
+    wget https://github.com/google/flatbuffers/archive/refs/tags/v"${flatc_ver}".tar.gz -O flatbuffers.tar.gz
+
+    flatc_actual_shasum="$(sha256sum flatbuffers.tar.gz | awk '{print $1}')"
+    if [ "${flatc_expected_shasum}" != "${flatc_actual_shasum}" ]
+    then
+        echo "error: flatc sha256sum did not match"
+        exit 1
+    fi
+
     tar xzvf flatbuffers.tar.gz
-    cd flatbuffers-2.0.8 && cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=Release && make && sudo make install && cd ..
+    cd flatbuffers-"${flatc_ver}" && cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=Release && make && sudo make install && cd ..
     rm -f flatbuffers.tar.gz
-    rm -rf flatbuffers-2.0.8
+    rm -rf flatbuffers-"${flatc_ver}"
 else
     echo "flatc is installed, skip..."
 fi
 
 # install-zlib
-wget https://zlib.net/fossils/zlib-1.2.12.tar.gz
-tar xzvf zlib-1.2.12.tar.gz
-cd zlib-1.2.12 && ./configure && sudo make install && cd ..
-rm -rf zlib-1.2.12
-rm -f zlib-1.2.12.tar.gz
+zlib_ver="1.2.12"
+zlib_expected_shasum="91844808532e5ce316b3c010929493c0244f3d37593afd6de04f71821d5136d9"
+
+wget https://zlib.net/fossils/zlib-"${zlib_ver}".tar.gz -O zlib.tar.gz
+zmake_actual_shasum="$(sha256sum zlib.tar.gz | awk '{print $1}')"
+if [ "${zlib_expected_shasum}" != "${zmake_actual_shasum}" ]
+then
+    echo "error: zmake sha256sum did not match"
+    exit 1
+fi
+
+tar xzvf zlib.tar.gz
+cd zlib-"${zlib_ver}" && ./configure && sudo make install && cd ..
+rm -rf zlib-"${zlib_ver}"
+rm -f zlib.tar.gz
 
 popd