Skip to content

Commit c509b82

Browse files
committed
undo testing changes
Signed-off-by: Arjun Raja Yogidas <[email protected]>
1 parent 1dcf0bf commit c509b82

File tree

6 files changed

+2
-29
lines changed

6 files changed

+2
-29
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,4 @@ jobs:
4747
- uses: actions/setup-go@v5
4848
with:
4949
go-version: ${{ env.GO_VERSION }}
50-
# - run: wget https://github.com/containerd/nerdctl/releases/download/v1.7.6/nerdctl-1.7.6-linux-amd64.tar.gz
51-
# - run: sudo tar Cxzvf /usr/local/bin nerdctl-1.7.6-linux-amd64.tar.gz
52-
# - run: sudo apt -y update && sudo apt -y upgrade && sudo apt-get -y install gcc-multilib
53-
# - run: uname -a
54-
# - run: GO_TEST_FLAGS="-run TestLazyPullWithSparseIndex -count=1" make integration
55-
- run: GO_TEST_FLAGS="-short -count=1" make integration
50+
- run: make integration

Dockerfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@ RUN apk add --no-cache \
3535
libc6-compat \
3636
libseccomp-dev \
3737
pigz \
38-
zlib-dev \
39-
strace
38+
zlib-dev
4039
RUN cp $GOPATH/src/github.com/awslabs/soci-snapshotter/out/soci /usr/local/bin/ && \
4140
cp $GOPATH/src/github.com/awslabs/soci-snapshotter/out/soci-snapshotter-grpc /usr/local/bin/ && \
4241
mkdir /etc/soci-snapshotter-grpc && \

fs/layer/node.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -303,8 +303,6 @@ func (n *node) Readdir(ctx context.Context) (fusefs.DirStream, syscall.Errno) {
303303
if errno != 0 {
304304
return nil, errno
305305
}
306-
307-
log.G(ctx).Debugf("Inside Readdir : %+v\n", ents)
308306
return fusefs.NewListDirStream(ents), 0
309307
}
310308

@@ -543,8 +541,6 @@ func (n *node) Listxattr(ctx context.Context, dest []byte) (uint32, syscall.Errn
543541
for k := range ent.Xattrs {
544542
attrs = append(attrs, []byte(k+"\x00")...)
545543
}
546-
547-
log.G(ctx).Debugf("Inside Listxattr : %+v\n", ent)
548544
if len(dest) < len(attrs) {
549545
return uint32(len(attrs)), syscall.ERANGE
550546
}

integration/metrics_test.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -143,10 +143,6 @@ func TestOverlayFallbackMetric(t *testing.T) {
143143
}
144144

145145
func TestFuseOperationFailureMetrics(t *testing.T) {
146-
if testing.Short() {
147-
t.Skip("skipping testing in short mode")
148-
}
149-
150146
const logFuseOperationConfig = `
151147
[fuse]
152148
log_fuse_operations = true
@@ -401,9 +397,6 @@ func checkFuseOperationFailureMetrics(t *testing.T, output string, metricToCheck
401397
metricCountSum := 0
402398

403399
lines := strings.Split(output, "\n")
404-
// t.Log("\n---------------------------- printinf outpurt of lines------------------------- \n")
405-
// t.Log(output)
406-
// t.Log("\n---------------------------- end------------------------- \n")
407400
for _, line := range lines {
408401
// skip non-fuse and fuse_mount_failure_count metrics
409402
if !strings.Contains(line, "fuse") || strings.Contains(line, commonmetrics.FuseMountFailureCount) {

integration/util_soci_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,6 @@ func buildIndex(sh *shell.Shell, src imageInfo, opt ...indexBuildOption) string
160160
"--platform", platforms.Format(src.platform), // this will make SOCI artifact available locally
161161
)
162162
if err != nil {
163-
fmt.Println("error line 163:", err)
164163
return ""
165164
}
166165

integration/util_test.go

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -717,22 +717,13 @@ func rebootContainerd(t *testing.T, sh *shell.Shell, customContainerdConfig, cus
717717
sh.Gox(containerdCmds...)
718718
snapshotterCmds := shell.C("/usr/local/bin/soci-snapshotter-grpc", "--log-level", sociLogLevel,
719719
"--address", snapshotterSocket)
720-
721720
if customSnapshotterConfig != "" {
722721
snapshotterCmds = addConfig(t, sh, customSnapshotterConfig, snapshotterCmds...)
723722
}
724723
outR, errR, err := sh.R(snapshotterCmds...)
725724
if err != nil {
726725
t.Fatalf("failed to create pipe: %v", err)
727726
}
728-
time.Sleep(2 * time.Second)
729-
pids, err := sh.OLog("pgrep", "-f", "soci")
730-
t.Log(string(pids))
731-
if err != nil {
732-
t.Fatal(err)
733-
}
734-
// sh.Gox("strace", "-f", "-p", string(pids))
735-
736727
reporter := testutil.NewTestingReporter(t)
737728
var m *testutil.LogMonitor = testutil.NewLogMonitor(reporter, outR, errR)
738729

0 commit comments

Comments
 (0)