Skip to content

Commit dbdef08

Browse files
committed
Address yamllint findings
Signed-off-by: David Son <[email protected]>
1 parent 2965b6a commit dbdef08

File tree

9 files changed

+62
-59
lines changed

9 files changed

+62
-59
lines changed

.github/ISSUE_TEMPLATE/bug_report.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,4 @@ body:
3333

3434
- type: textarea
3535
attributes:
36-
label: Any additional context or information about the bug
36+
label: Any additional context or information about the bug

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ contact_links:
66
In most cases, GitHub Discussions is the preferred place to ask a question,
77
and visible to more users. If you encountered a bug or request a feature,
88
please use the issue template. Otherwise, please consider asking in GitHub
9-
Discussions first.
9+
Discussions first.

.github/ISSUE_TEMPLATE/feature_request.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,4 @@ body:
2121

2222
- type: textarea
2323
attributes:
24-
label: Any additional context or information about the feature request
24+
label: Any additional context or information about the feature request

.github/dependabot.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
version: 2
22
updates:
3-
3+
44
# Automatic upgrade for go modules.
55
- package-ecosystem: "gomod"
66
directory: "/"
77
schedule:
88
interval: "daily"
99
ignore:
10-
# skip grpc because the current latest is not compatible with containerd 1.7
11-
# skip k8s deps since they use the latest go version/features that may not be in the go version soci uses
10+
# skip grpc because the current latest not compatible with containerd 1.7
11+
# skip k8s deps since they use the latest go version/features that may
12+
# not be in the go version soci uses
1213
# Also ignored in /scripts/bump-deps.sh
1314
- dependency-name: "google.golang.org/grpc"
1415
- dependency-name: "k8s.io/*"
@@ -19,8 +20,9 @@ updates:
1920
schedule:
2021
interval: "daily"
2122
ignore:
22-
# skip grpc because the current latest is not compatible with containerd 1.7
23-
# skip k8s deps since they use the latest go version/features that may not be in the go version soci uses
23+
# skip grpc because the current latest not compatible with containerd 1.7
24+
# skip k8s deps since they use the latest go version/features that may
25+
# not be in the go version soci uses
2426
# Also ignored in /scripts/bump-deps.sh
2527
- dependency-name: "github.com/awslabs/soci-snapshotter"
2628
- dependency-name: "google.golang.org/grpc"

.github/workflows/benchmark_visualization.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Visualize Benchmark and upload results
22

33
on:
44
push:
5-
branches: [ main ]
5+
branches: [main]
66
paths:
77
- '**'
88
- '!docs/**' # ignore docs changes
@@ -14,7 +14,7 @@ permissions:
1414

1515
env:
1616
GO_VERSION: '1.21.9'
17-
17+
1818
jobs:
1919
benchmark:
2020
runs-on: ubuntu-20.04
@@ -29,13 +29,13 @@ jobs:
2929
go-version: ${{ env.GO_VERSION }}
3030
- run: make
3131
- name: Run benchmark
32-
run: make benchmarks-perf-test
32+
run: make benchmarks-perf-test
3333
- name: Upload latest benchmark result
3434
uses: actions/upload-artifact@v4
3535
with:
3636
name: benchmark-result-artifact
3737
path: ${{github.workspace}}/benchmark/performanceTest/output/results.json
38-
38+
3939
download-and-convert-benchmark-result-to-visualization-data:
4040
runs-on: ubuntu-20.04
4141
needs: benchmark
@@ -52,10 +52,10 @@ jobs:
5252
- name: Change permission of visualization-data-converter.sh
5353
run: chmod +x ${{github.workspace}}/scripts/visualization-data-converter.sh
5454
- name: Convert benchmark result to visualization data
55-
run: ${{github.workspace}}/scripts/visualization-data-converter.sh ${{github.workspace}}/results.json ${{github.workspace}}/current
55+
run: ${{github.workspace}}/scripts/visualization-data-converter.sh ${{github.workspace}}/results.json ${{github.workspace}}/current
5656
- name: Build matrix of filepaths
5757
id: set-matrix
58-
# Create a JSON array with the file paths and store it in the 'files' output
58+
# Create a JSON array with the file paths and store it in the 'files' output
5959
run: echo "files=$(find ${{github.workspace}}/current -type f -name '*.json' -printf '%p\n' | jq -R . | jq -cs .)" >> $GITHUB_OUTPUT
6060
- name: Upload visualization files as github artifacts
6161
uses: actions/upload-artifact@v4
@@ -84,15 +84,15 @@ jobs:
8484
with:
8585
name: benchmark-gh-pages-artifact
8686
path: ${{github.workspace}}/current
87-
87+
8888
- name: Extract file names
8989
id: get_filename
9090
run: |
9191
# Get the filename without the path
9292
filename=$(basename "${{ matrix.file }}")
9393
# Remove the .json extension
9494
filename_without_extension="${filename%.json}"
95-
echo "filename=$filename_without_extension" >> $GITHUB_OUTPUT
95+
echo "filename=$filename_without_extension" >> $GITHUB_OUTPUT
9696
9797
- name: Run benchmark action
9898
uses: benchmark-action/github-action-benchmark@v1

.github/workflows/bump-deps.yml

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ name: Bump Deps
44

55
on:
66
schedule:
7-
- cron: '0 10 * * 2' # weekly at 10AM Tuesday
7+
- cron: '0 10 * * 2' # weekly at 10AM Tuesday
88
workflow_dispatch:
99

1010
env:
@@ -23,19 +23,19 @@ jobs:
2323
runs-on: ubuntu-20.04
2424

2525
steps:
26-
- uses: actions/checkout@v4
27-
- uses: actions/setup-go@v5
28-
with:
29-
go-version: ${{ env.GO_VERSION }}
26+
- uses: actions/checkout@v4
27+
- uses: actions/setup-go@v5
28+
with:
29+
go-version: ${{ env.GO_VERSION }}
3030

31-
- run: ./scripts/bump-deps.sh
32-
- name: Create Pull Request
33-
uses: peter-evans/create-pull-request@v6
34-
with:
35-
title: "Bump dependencies using scripts/bump-deps.sh"
36-
commit-message: "Bump dependencies using scripts/bump-deps.sh"
37-
body: "This PR created by [create-pull-request](https://github.com/peter-evans/create-pull-request) must be closed and reopened manually to trigger automated checks."
38-
labels: dependencies
39-
delete-branch: true
40-
author: "GitHub <[email protected]>"
41-
signoff: true
31+
- run: ./scripts/bump-deps.sh
32+
- name: Create Pull Request
33+
uses: peter-evans/create-pull-request@v6
34+
with:
35+
title: "Bump dependencies using scripts/bump-deps.sh"
36+
commit-message: "Bump dependencies using scripts/bump-deps.sh"
37+
body: "This PR created by [create-pull-request](https://github.com/peter-evans/create-pull-request) must be closed and reopened manually to trigger automated checks."
38+
labels: dependencies
39+
delete-branch: true
40+
author: "GitHub <[email protected]>"
41+
signoff: true

.github/workflows/prebuild.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ name: Pre-build
22

33
on:
44
push:
5-
branches: [ 'main', 'release/**']
5+
branches: ['main', 'release/**']
66
pull_request:
7-
branches: [ 'main', 'release/**']
7+
branches: ['main', 'release/**']
88

99
env:
1010
GO_VERSION: '1.21.9'
@@ -37,10 +37,10 @@ jobs:
3737
- name: Pull latest awslabs/git-secrets repo
3838
uses: actions/checkout@v4
3939
with:
40-
repository: awslabs/git-secrets
41-
ref: 1.3.0
42-
fetch-tags: true
43-
path: git-secrets
40+
repository: awslabs/git-secrets
41+
ref: 1.3.0
42+
fetch-tags: true
43+
path: git-secrets
4444
- name: Install git secrets from source
4545
run: sudo make install
4646
working-directory: git-secrets
@@ -49,7 +49,7 @@ jobs:
4949
run: |
5050
git secrets --register-aws
5151
git secrets --scan-history
52-
52+
5353
lint:
5454
strategy:
5555
matrix:

.github/workflows/releases.yml

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -20,30 +20,30 @@ jobs:
2020
DYNAMIC_BINARY_NAME: ''
2121
STATIC_BINARY_NAME: ''
2222
steps:
23-
- uses: actions/checkout@v4
24-
- name: Setup and export variables
25-
run: |
26-
export release_tag=${GITHUB_REF#refs/*/} # Strip down to raw tag name
27-
export release_version=${release_tag/v/} # Remove v from tag name
23+
- uses: actions/checkout@v4
24+
- name: Setup and export variables
25+
run: |
26+
export release_tag=${GITHUB_REF#refs/*/} # Strip down to raw tag name
27+
export release_version=${release_tag/v/} # Remove v from tag name
2828
29-
echo "RELEASE_TAG=${release_tag}" >> $GITHUB_ENV
30-
echo "DYNAMIC_BINARY_NAME=soci-snapshotter-${release_version}-linux-amd64.tar.gz" >> $GITHUB_ENV
31-
echo "STATIC_BINARY_NAME=soci-snapshotter-${release_version}-linux-amd64-static.tar.gz" >> $GITHUB_ENV
32-
33-
mkdir release
34-
- name: Create release binaries
35-
run: make RELEASE_TAG=${{ env.RELEASE_TAG }} release
36-
- uses: actions/upload-artifact@v4
37-
with:
38-
name: artifacts
39-
path: release/
40-
if-no-files-found: error
29+
echo "RELEASE_TAG=${release_tag}" >> $GITHUB_ENV
30+
echo "DYNAMIC_BINARY_NAME=soci-snapshotter-${release_version}-linux-amd64.tar.gz" >> $GITHUB_ENV
31+
echo "STATIC_BINARY_NAME=soci-snapshotter-${release_version}-linux-amd64-static.tar.gz" >> $GITHUB_ENV
32+
33+
mkdir release
34+
- name: Create release binaries
35+
run: make RELEASE_TAG=${{ env.RELEASE_TAG }} release
36+
- uses: actions/upload-artifact@v4
37+
with:
38+
name: artifacts
39+
path: release/
40+
if-no-files-found: error
4141

4242
outputs:
4343
release_tag: ${{ env.RELEASE_TAG }}
4444
dynamic_binary_name: ${{ env.DYNAMIC_BINARY_NAME }}
4545
static_binary_name: ${{ env.STATIC_BINARY_NAME }}
46-
46+
4747
validate-artifacts:
4848
needs: generate-artifacts
4949
runs-on: ubuntu-20.04

.golangci.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,9 @@ issues:
1818
exclude-rules:
1919
- linters:
2020
- revive
21-
# Ignore unused parameter rule. It's not enforced by go and it can make it hard
22-
# to understand what the unused parameter was supposed to be used for.
21+
# Ignore unused parameter rule. It's not enforced by go and
22+
# it can make it hard to understand what the unused parameter
23+
# was supposed to be used for.
2324
text: "unused-parameter:"
2425

2526
run:

0 commit comments

Comments
 (0)