Skip to content

Commit 130869e

Browse files
committed
Use Hash#fetch for connpass to fetch responses to validate if given column exists
1 parent 2ce7bd5 commit 130869e

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed

lib/upcoming_events/tasks/connpass.rb

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,21 +12,24 @@ def run
1212
dojo.dojo_event_services.for(:connpass).pluck(:group_id)
1313
end
1414

15-
@client.fetch_events(**@params.merge(group_id: group_ids)).each do |e|
16-
dojo_event_service = DojoEventService.find_by(group_id: e.dig('series', 'id').to_s)
15+
events = @client.fetch_events(**@params.merge(group_id: group_ids))
16+
puts "[connpass] Fetched events: #{events.size}"
17+
events.each do |e|
18+
puts "[connpass] event_id: #{e.fetch('id')}, title: #{e.fetch('title')}"
19+
dojo_event_service = DojoEventService.find_by(group_id: e.dig('group', 'id').to_s)
1720
next unless dojo_event_service
1821

19-
record = dojo_event_service.upcoming_events.find_or_initialize_by(event_id: e['event_id'])
22+
record = dojo_event_service.upcoming_events.find_or_initialize_by(event_id: e.fetch('id'))
2023
record.update!(service_name: dojo_event_service.name,
21-
event_title: e['title'],
22-
event_url: e['event_url'],
23-
event_at: Time.zone.parse(e['started_at']),
24-
event_end_at: Time.zone.parse(e['ended_at']),
25-
participants: e['accepted'],
26-
event_update_at: Time.zone.parse(e['updated_at']),
27-
address: e['address'],
28-
place: e['place'],
29-
limit: e['limit'])
24+
event_title: e.fetch('title'),
25+
event_url: e.fetch('url'),
26+
event_at: Time.zone.parse(e.fetch('started_at')),
27+
event_end_at: Time.zone.parse(e.fetch('ended_at')),
28+
participants: e.fetch('accepted'),
29+
event_update_at: Time.zone.parse(e.fetch('updated_at')),
30+
address: e.fetch('address'),
31+
place: e.fetch('place'),
32+
limit: e.fetch('limit'))
3033
end
3134
end
3235

lib/upcoming_events/tasks/doorkeeper.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ def run
1111
@dojos.each do |dojo|
1212
dojo.dojo_event_services.for(:doorkeeper).each do |dojo_event_service|
1313
events = @client.fetch_events(**@params.merge(group_id: dojo_event_service.group_id))
14+
puts "[doorkeeper] dojo_id: #{dojo.id}, group_id: #{dojo_event_service.group_id}, fetched events: #{events&.size || 0}"
1415
(events || []).compact.each do |e|
16+
puts "[doorkeeper] event_id: #{e['id']}, title: #{e['title']}"
1517
next unless e['group'].to_s == dojo_event_service.group_id
1618

1719
record = dojo_event_service.upcoming_events.find_or_initialize_by(event_id: e['id'])

0 commit comments

Comments
 (0)