Skip to content

Commit 40520b2

Browse files
committed
refactor: SakuraServerUserAgentクラスにデフォルトパラメータを実装
- initialize メソッドに本番環境のデフォルト値を設定 - zone: '31002' (石狩第二) - packet_filter_id: '112900922505' - Rakefileのserver:listタスクからハードコーディングを削除 - DRY原則に従い、デフォルト値の重複を解消
1 parent 48d0b00 commit 40520b2

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

Rakefile

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -341,12 +341,8 @@ namespace :server do
341341
server_statuses = {}
342342
if ENV['SACLOUD_ACCESS_TOKEN'] && ENV['SACLOUD_ACCESS_TOKEN_SECRET']
343343
begin
344-
client = SakuraServerUserAgent.new(
345-
zone: "31002",
346-
zone_id: "is1b",
347-
packet_filter_id: '112900922505',
348-
verbose: false
349-
)
344+
# デフォルトパラメータ(石狩第二)が自動的に使用される
345+
client = SakuraServerUserAgent.new
350346
servers_data = client.get_servers()
351347
if servers_data && servers_data['Servers']
352348
servers_data['Servers'].each do |server|

scripts/sakura_server_user_agent.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ def self.normalize_ip_address(ip)
5555
end
5656

5757
# jsのserver.createで使っているフィールドを参考
58-
def initialize(zone:0, packet_filter_id:nil, name:nil, description:nil, zone_id:"is1b",
58+
# デフォルト値を本番環境(石狩第二)に設定
59+
def initialize(zone:"31002", packet_filter_id:'112900922505', name:nil, description:nil, zone_id:"is1b",
5960
tags:nil, pubkey:nil, resolve:nil, verbose:false)
6061
@zone = zone
6162
@packet_filter_id = packet_filter_id

0 commit comments

Comments
 (0)