Fix crash on startup, it's a race condition in the module progress signal subscribers.

The Splash screen would not unsubscribe from the progress channel, even thought the
controls have already been destroyed. The next progress call will run into a crash
since the Splash dialog just schedules its deletion (which would trigger the auto-unsubscribe,
but it comes too late).

Author: codereader

radiant/ui/splash/Splash.cpp

@@ -87,8 +87,11 @@ Splash::Splash() :
 	Show();
 
     // Subscribe to the post-module init event to destroy ourselves
-    module::GlobalModuleRegistry().signal_allModulesInitialised().connect(
-        sigc::hide_return(sigc::mem_fun(this, &Splash::Destroy)));
+    module::GlobalModuleRegistry().signal_allModulesInitialised().connect([this]
+    { 
+      _moduleProgressConnection.disconnect();
+      Destroy();
+    });
 }
 
 void Splash::queueDraw()
@@ -127,7 +130,7 @@ Splash& Splash::Instance()
 void Splash::OnAppStartup()
 {
 	// Connect the module progress callback
-	module::GlobalModuleRegistry().signal_moduleInitialisationProgress().connect(
+  Instance()._moduleProgressConnection = module::GlobalModuleRegistry().signal_moduleInitialisationProgress().connect(
 		sigc::mem_fun(Instance(), &Splash::setProgressAndText));
 }
 

radiant/ui/splash/Splash.h

@@ -20,6 +20,8 @@ class Splash :
 	wxGauge* _progressBar;
 	wxImagePanel* _imagePanel;
 
+  sigc::connection _moduleProgressConnection;
+
     // Private constructor, creates all the widgets
     Splash();