Skip to content

Commit 8de178b

Browse files
authored
Handle Site=None when getting absolute media URL (#79)
1 parent ab1190b commit 8de178b

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

docs/customizing/customize-meta.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ first make a property on the page model:
189189
# structured data image fields. This will render the image in
190190
# 1:1, 4:3, and 16:9 aspect ratios with very high resolution
191191
# and return a list of URLs.
192-
"image": get_struct_data_images(self.recipe_photo),
192+
"image": get_struct_data_images(self.get_site(), self.recipe_photo),
193193
194194
"author": {
195195
"@type": "Person",

wagtailseo/utils.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
from datetime import time
55
from json import JSONEncoder
66
from typing import List
7+
from typing import Optional
78
from typing import Union
89

910
from django.conf import settings
@@ -28,7 +29,7 @@ def serialize_date(date: Union[date, datetime, time]) -> str:
2829
return date.isoformat()
2930

3031

31-
def get_absolute_media_url(site: Site) -> str:
32+
def get_absolute_media_url(site: Optional[Site]) -> str:
3233
"""
3334
Returns an absolute base URL for media files.
3435
@@ -40,7 +41,7 @@ def get_absolute_media_url(site: Site) -> str:
4041
:rtype: str
4142
:returns: The absolute base URL for media files of this site.
4243
"""
43-
if MEDIA_IS_ABSOLUTE:
44+
if MEDIA_IS_ABSOLUTE or site is None:
4445
return ""
4546

4647
return site.root_url

0 commit comments

Comments
 (0)