fix test cases + minor code re-factoring

Author: codereverser

casparser/process/cas_detailed.py

@@ -39,7 +39,7 @@ def get_transaction_type(
             txn_type = TransactionType.STT_TAX
         elif "stamp" in description:
             txn_type = TransactionType.STAMP_DUTY_TAX
-        elif ("segregate" in description.lower()) or ("segregation" in description.lower()):
+        elif "segregat" in description:
             txn_type = TransactionType.SEGREGATION
         else:
             txn_type = TransactionType.MISC

tests/test_process.py

@@ -41,7 +41,9 @@ def test_transaction_type(self):
             None,
         )
         assert get_transaction_type("Address updated", None) == (TransactionType.MISC, None)
-        assert get_transaction_type("***STT paid ***", None) == (TransactionType.TAX, None)
+        assert get_transaction_type("***STT paid ***", None) == (TransactionType.STT_TAX, None)
+        assert get_transaction_type("***stamp duty***", None) == (TransactionType.STAMP_DUTY_TAX, None)
+        assert get_transaction_type("Creation of units - Segregated portfolio", None) == (TransactionType.SEGREGATION, None)
         assert get_transaction_type("***Random text***", Decimal(0.0)) == (
             TransactionType.UNKNOWN,
             None,