Fix consistency issues with setName and submitNameChange endpoints (soon to be deprecated)

Author: codergautam

api/setName.js

@@ -8,6 +8,7 @@ import { Filter } from "bad-words";
 import UserStatsService from "../components/utils/userStatsService.js";
 import ModerationLog from "../models/ModerationLog.js";
 import Report from "../models/Report.js";
+import NameChangeRequest from "../models/NameChangeRequest.js";
 const filter = new Filter();
 
 export default async function handler(req, res) {
@@ -69,6 +70,48 @@ export default async function handler(req, res) {
       }
     }
 
+    // If user has a forced name change, submit for moderator review instead of direct change
+    if (user.pendingNameChange) {
+      // Check if user already has a pending request
+      const existingRequest = await NameChangeRequest.findOne({
+        'user.accountId': user._id.toString(),
+        status: 'pending'
+      });
+
+      if (existingRequest) {
+        // Update the existing request with the new name
+        await NameChangeRequest.findByIdAndUpdate(existingRequest._id, {
+          requestedUsername: username,
+          updatedAt: new Date()
+        });
+
+        return res.status(200).json({
+          success: true,
+          pendingReview: true,
+          message: 'Your name change request has been updated. Please wait for moderator review.',
+          requestId: existingRequest._id
+        });
+      }
+
+      // Create new name change request
+      const nameRequest = await NameChangeRequest.create({
+        user: {
+          accountId: user._id.toString(),
+          currentUsername: user.username
+        },
+        requestedUsername: username,
+        reason: user.pendingNameChangeReason || 'Forced name change',
+        status: 'pending'
+      });
+
+      return res.status(200).json({
+        success: true,
+        pendingReview: true,
+        message: 'Your name change request has been submitted. Please wait for moderator review.',
+        requestId: nameRequest._id
+      });
+    }
+
     if (user.username) {
       // this means this is a name change, not a first time name set
       // check if the user has waited long enough since the last name change

api/submitNameChange.js

@@ -7,6 +7,8 @@ import NameChangeRequest from '../models/NameChangeRequest.js';
  * For users who have been forced to change their name.
  * Submits a new username for moderator review.
  */
+
+// TODO: FUNCTIONALTIY MERGED TO setName.js, SHOULD BE DEPRECATED SOON AFTER UPDATING CLIENT.
 export default async function handler(req, res) {
   if (req.method !== 'POST') {
     return res.status(405).json({ message: 'Method not allowed' });
@@ -26,15 +28,18 @@ export default async function handler(req, res) {
   // Validate username format
   const trimmedUsername = newUsername.trim();
 
-  if (trimmedUsername.length < 3 || trimmedUsername.length > 20) {
-    return res.status(400).json({ message: 'Username must be between 3 and 20 characters' });
+  if (trimmedUsername.length < 3 || trimmedUsername.length > 30) {
+    return res.status(400).json({ message: 'Username must be between 3 and 30 characters' });
   }
 
-  // Only allow alphanumeric, underscore, and hyphen
-  if (!/^[a-zA-Z0-9_-]+$/.test(trimmedUsername)) {
-    return res.status(400).json({ message: 'Username can only contain letters, numbers, underscores, and hyphens' });
+  // Only allow alphanumeric, underscores
+  if (!/^[a-zA-Z0-9_]+$/.test(trimmedUsername)) {
+    return res
+      .status(400)
+      .json({
+        message: "Username must contain only letters, numbers, and underscores",
+      });
   }
-
   try {
     // Get the user
     const user = await User.findOne({ secret });