desktop notifications will only be issued when running on a DE

Author: s-n-g

pyradio/config

@@ -141,8 +141,8 @@ force_transparency = False
 calculated_color_factor = 0
 
 # Console theme
-# This is the theme to be used when a PyRasio is executed either in a linux
-# virtual console, or on a terminal that does not support color change.
+# This is the theme to be used when a PyRadio is executed either in a Linux
+# Virtual Console, or on a terminal that does not support color change.
 # Possible values: dark / light
 #
 # Default value: dark

pyradio/config.py

@@ -33,6 +33,7 @@
 from .server import IPsWithNumbers
 from .xdg import XdgDirs, XdgMigrate, CheckDir
 from .install import get_a_linux_resource_opener
+from .html_help import is_graphical_environment_running
 HAS_REQUESTS = True
 
 try:
@@ -1494,7 +1495,9 @@ def enable_mouse(self, val):
 
     @property
     def enable_notifications(self):
-        return self.opts['enable_notifications'][1]
+        if is_graphical_environment_running():
+            return self.opts['enable_notifications'][1]
+        return False
 
     @enable_notifications.setter
     def enable_notifications(self, val):

pyradio/html_help.py

@@ -2,7 +2,7 @@
 import subprocess
 import logging
 from sys import platform
-from os import path, environ, listdir
+from os import path, environ, listdir, getenv
 from shutil import which
 from .install import get_a_linux_resource_opener
 try:
@@ -29,6 +29,9 @@ def convert_to_md(a_file):
 
 def is_graphical_environment_running():
     global HAS_GRAPHICAL_ENV
+    if getenv('TERM') == 'linux':
+        HAS_GRAPHICAL_ENV = 2
+        return False
     if HAS_GRAPHICAL_ENV == 1:
         return True
     elif HAS_GRAPHICAL_ENV == 2:

pyradio/log.py

@@ -466,7 +466,8 @@ def _show_notification(self, msg):
                                 self._repeat_notification.reset_timer()
 
             else:
-                if self._cnf._notification_command:
+                if self._cnf._notification_command and \
+                        self._cnf.enable_notifications:
                     d_title, d_msg = self._get_desktop_notification_data(msg)
                     if d_msg:
                         if self._cnf._current_notification_message != d_msg: