fix: sender error test and remove ts-node

Author: magne

package-lock.json

@@ -55,7 +55,6 @@
     "globals": "^16.2.0",
     "got": "^14.4.7",
     "prettier": "3.5.3",
-    "ts-node": "^10.9.2",
     "tsup": "^8.5.0",
     "typescript": "^5.8.3",
     "typescript-eslint": "^8.33.1",

package.json

@@ -83,7 +83,6 @@ export class AmqpPublisher implements Publisher {
             return promise.resolve({ delivery: context.delivery, outcome: getOutcomeStateFrom(senderEvent) })
           }
         }
-        return Promise.reject("Message cannot be handled successfully")
       }
     }
     this.errorMessageHandler = (context: EventContext, errorEvent: RejectableSenderEvents, deliveryId: number) => {
@@ -93,7 +92,6 @@ export class AmqpPublisher implements Publisher {
         const error = new Error(`SenderLink error ${errorEvent}: ${inspect(context.error)}`)
         return promise.reject(error)
       }
-      return Promise.reject("Unhandled error")
     }
 
     this.registerEventListeners()

src/publisher.ts

@@ -10,8 +10,6 @@ import {
   createBinding,
   cleanRabbit,
   deleteExchange,
-  expectToThrowAsync,
-  deleteQueue,
 } from "../support/util.js"
 import { Connection } from "../../src/connection.js"
 import { OutcomeState } from "../../src/utils.js"
@@ -74,20 +72,11 @@ describe("Publisher", () => {
     expect(publishResult.outcome).to.eql(OutcomeState.RELEASED)
   })
 
-  test.skip("publish should throw if exchange is deleted", async () => {
+  test("publish should throw if exchange is deleted", async () => {
     const publisher = await connection.createPublisher({ exchange: { name: exchangeName, routingKey: bindingKey } })
     await deleteExchange(exchangeName)
 
-    await expectToThrowAsync(() => publisher.publish(createAmqpMessage({ body: "Hello World!" })), Error)
-    // await expect(publisher.publish(createAmqpMessage({ body: "Hello World!" }))).rejects.toThrowError()
-  })
-
-  test.skip("publish should throw if queue is deleted", async () => {
-    const publisher = await connection.createPublisher({ queue: { name: queueName } })
-    await deleteQueue(queueName)
-
-    await expectToThrowAsync(() => publisher.publish(createAmqpMessage({ body: "Hello World!" })), Error)
-    // await expect(publisher.publish(createAmqpMessage({ body: "Hello World!" }))).rejects.toThrowError()
+    await expect(publisher.publish(createAmqpMessage({ body: "Hello World!" }))).rejects.toThrowError(Error)
   })
 
   test("publish a message with address to an exchange", async () => {

test/e2e/publisher.test.ts

@@ -329,24 +329,3 @@ export async function eventually(fn: Function, timeout = 5000) {
     }
   }
 }
-
-export async function expectToThrowAsync(
-  method: () => Promise<unknown>,
-  // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
-  expectedError: Function | Error,
-  errorMessage: string | RegExp | null = null
-): Promise<void> {
-  let error = null
-  try {
-    await method()
-  } catch (err) {
-    error = err
-  }
-  expect(error).instanceOf(expectedError)
-  if (errorMessage instanceof RegExp) {
-    expect((error as { message: string }).message).match(errorMessage)
-  }
-  if (typeof errorMessage === "string") {
-    expect((error as { message: string }).message).eql(errorMessage)
-  }
-}