chore: fix pr comments and add errors in promise rejection

Author: magne

src/connection.ts

@@ -2,6 +2,7 @@ import { ConnectionEvents, Connection as RheaConnection } from "rhea"
 
 export interface Connection {
   close(): Promise<boolean>
+  isOpen(): boolean
 }
 
 export class AmqpConnection implements Connection {
@@ -17,11 +18,14 @@ export class AmqpConnection implements Connection {
         return res(true)
       })
       this.rheaConnection.once(ConnectionEvents.connectionError, (context) => {
-        console.error("ERROR: ", context.connection.error)
-        return rej(false)
+        return rej(new Error("Connection error: " + context.connection.error))
       })
 
       this.rheaConnection.close()
     })
   }
+
+  public isOpen(): boolean {
+    return this.rheaConnection.is_open()
+  }
 }

src/environment.ts

@@ -20,7 +20,7 @@ export class AmqpEnvironment implements Environment {
   private readonly username: string
   private readonly password: string
   private readonly container: Container
-  private readonly connections: Connection[] = []
+  private connections: Connection[] = []
 
   constructor({ host, port, username, password }: EnvironmentParams) {
     this.host = host
@@ -38,27 +38,31 @@ export class AmqpEnvironment implements Environment {
     return connection
   }
 
-  async close(): Promise<void> {
-    await Promise.allSettled(
-      this.connections.map(async (c) => {
-        await c.close()
-      })
-    )
-  }
-
   private async openConnection(): Promise<RheaConnection> {
     return new Promise((res, rej) => {
       this.container.once(ConnectionEvents.connectionOpen, (context) => {
         return res(context.connection)
       })
       this.container.once(ConnectionEvents.error, (context) => {
-        console.log(context)
-        rej()
+        return rej(context.error ?? new Error("Connection error occurred"))
       })
 
       this.container.connect({ host: this.host, port: this.port, username: this.username, password: this.password })
     })
   }
+
+  async close(): Promise<void> {
+    await this.closeConnections()
+    this.connections = []
+  }
+
+  private async closeConnections(): Promise<void> {
+    await Promise.allSettled(
+      this.connections.map(async (c) => {
+        if (c.isOpen()) await c.close()
+      })
+    )
+  }
 }
 
 export function createEnvironment(params: EnvironmentParams): Environment {

test/unit/rhea/connection.test.ts

@@ -50,8 +50,7 @@ async function open(container: Container, params: ConnectionOptions): Promise<Co
       return res(context.connection)
     })
     container.once("error", (context) => {
-      console.log(context)
-      rej()
+      return rej(context.connection.error)
     })
     container.connect(params)
   })
@@ -63,8 +62,7 @@ async function openReceiver(connection: Connection) {
       return res(context.receiver)
     })
     connection.once("receiver_error", (context) => {
-      console.log(context)
-      rej()
+      return rej(context.connection.error)
     })
     connection.open_receiver({
       snd_settle_mode: 1,
@@ -83,8 +81,7 @@ async function openSender(connection: Connection) {
       return res(context.sender)
     })
     connection.once("sender_error", (context) => {
-      console.log(context)
-      rej()
+      return rej(context.connection.error)
     })
     connection.open_sender({
       snd_settle_mode: 1,